feat(api) Add Live API - #694
Conversation
Castiron-Internal-PR: openai/openai-ruby-internal#86 Castiron-Source-SHA: b22ea7f177fc54317c450e03754f3dbd7bef36ed Castiron-Public-Base-SHA: 7f19b93
Castiron custom code✅ No new custom-code files detected. 65 mixed files remain; 1 existing customization changed; 6 generated baselines changed. Compared
58 existing customizations unchanged
18 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 34506703487 --repo openai/openai-ruby \
--name castiron-custom-code-34506703487-1 --dir /tmp/castiron-custom-code-34506703487-1
git apply --stat /tmp/castiron-custom-code-34506703487-1/custom-code.patch
cat /tmp/castiron-custom-code-34506703487-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 7f19b932549bd7d4376e6ca91c7c75f9b856ae83 7f0bb9ff05e61442e18479774ea0d8abccba23ec
python3 scripts/castiron/custom_code_report.py report \
--base 7f19b932549bd7d4376e6ca91c7c75f9b856ae83 \
--head 7f0bb9ff05e61442e18479774ea0d8abccba23ec --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-7f0bb9ff05e6
cat /tmp/castiron-custom-code-7f0bb9ff05e6/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f0bb9ff05
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| body: parsed, | ||
| model: OpenAI::Models::Live::LiveCreateResponse, | ||
| security: {bearer_auth: true}, | ||
| options: options |
There was a problem hiding this comment.
When /live/sessions returns a retryable 408/409/429/5xx response, forwarding the unchanged options applies the client's default two retries, potentially replaying the SDP offer after the first request already allocated a session and leaving duplicate/orphaned sessions. Realtime::Calls#create explicitly defaults call allocation to zero retries while preserving caller overrides; apply the same behavior here and to Sessions#fork, with a focused retry regression test.
AGENTS.md reference: AGENTS.md:L56-L60
Useful? React with 👍 / 👎.
| parsed, options = OpenAI::Live::SessionAcceptParams.dump_request(params) | ||
| @client.request( | ||
| method: :post, | ||
| path: ["live/sessions/%1$s/accept", session_id], |
There was a problem hiding this comment.
When info or debug logging is enabled, this interpolated path reaches Logging.safe_url and Logging.safe_path verbatim; the sanitizer only redacts /realtime/calls/..., so the live_... identifier appears in request and completion logs for this and every other new Live session endpoint. Because these backend-held identifiers are used for session control and sideband connections, extend route redaction to Live paths and add focused logging coverage.
AGENTS.md reference: AGENTS.md:L43-L46
Useful? React with 👍 / 👎.
1 participant
Uh oh!
There was an error while loading. Please reload this page.