feat(api): expose image tool call metadata - #690
Open
markstuart-oai wants to merge 1 commit into
Open
Conversation
Castiron-Internal-PR: openai/openai-ruby-internal#99 Castiron-Source-SHA: 55d93127d5463681e582bdf4f07676b087b26720 Castiron-Public-Base-SHA: acf5db8
Contributor
Castiron custom codeMixed files: 65 → 68 3 newly customized · 0 customizations removed · 0 existing customizations changed · 40 generated baselines changed Compared
28 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 34317512515 --repo openai/openai-ruby \
--name castiron-custom-code-34317512515-1 --dir /tmp/castiron-custom-code-34317512515-1
git apply --stat /tmp/castiron-custom-code-34317512515-1/custom-code.patch
cat /tmp/castiron-custom-code-34317512515-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin acf5db808c521a1793439fe4e2975c78a9e9e73b 10c23430a98bf3ab1bb70d66a479a3c8bd813a22
python3 scripts/castiron/custom_code_report.py report \
--base acf5db808c521a1793439fe4e2975c78a9e9e73b \
--head 10c23430a98bf3ab1bb70d66a479a3c8bd813a22 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-10c23430a98b
cat /tmp/castiron-custom-code-10c23430a98b/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
markstuart-oai
marked this pull request as ready for review
September 9, 2026 06:04
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
jbeckwith-oai
approved these changes
Sep 9, 2026
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the exact public promotion. Its SDK content matches the already-reviewed internal candidate, apart from the expected public generation marker. Existing required fields remain required; new metadata preserves optional/nil behavior and custom size strings, service-account expiry remains optional, and exact-head CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose image tool call metadata through model accessors and support service-account API-key expiry.
Changes