refactor(plugin): preserve Windows filenames in native helpers - #798
Open
kmbroai wants to merge 6 commits into
Open
refactor(plugin): preserve Windows filenames in native helpers#798kmbroai wants to merge 6 commits into
kmbroai wants to merge 6 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
3 tasks
kmbroai
force-pushed
the
dev/kyleb/python-free-windows-wide-paths
branch
from
September 3, 2026 18:27
98e64e2 to
f5bfd66
Compare
kmbroai
force-pushed
the
dev/kyleb/python-free-windows-wide-paths
branch
from
September 3, 2026 19:17
f5bfd66 to
0f1995a
Compare
kmbroai
force-pushed
the
dev/kyleb/python-free-windows-wide-paths
branch
from
September 4, 2026 22:44
0f1995a to
08a2ac5
Compare
kmbroai
force-pushed
the
dev/kyleb/python-free-windows-wide-paths
branch
from
September 4, 2026 23:39
08a2ac5 to
6014da9
Compare
mldangelo-oai
left a comment
Collaborator
There was a problem hiding this comment.
Re-reviewed the exact current head after the latest fixes. The four earlier threads are resolved. I found one remaining Windows path correctness bug and two nonblocking simplifications.
kmbroai
force-pushed
the
dev/kyleb/python-free-windows-wide-paths
branch
from
September 5, 2026 00:51
6014da9 to
c58c6d0
Compare
kmbroai
force-pushed
the
dev/kyleb/python-free-windows-wide-paths
branch
from
September 5, 2026 01:22
c58c6d0 to
b3609d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve Windows filenames when replacing Python path handling with TypeScript. Helpers receive original UTF-16 arguments, environment values, directory names, and paths, including lone surrogates.
Changes
std::fs::read_dirand cached entry types for one typed directory enumerator, preserving raw names and numeric Windows errors.std::path::absolute, preserving native errors and the existing empty-input result. Normalize verbatim paths below their drive or share root, including doubled separators and parent traversal.Testing
Fileintegration: both MSVC-target Clippy checks, CI-tool compilation, proof syntax, Rust/TypeScript formatting, workflow lint, Ruff, portable source checks, and all nine checker tests passed.Risk and rollout
Stacked on #797. Adds native operations without changing command routing or public CLI syntax. Junction directory entries now carry Rust's directory and symbolic-link flags; the following resolver still excludes their traversal. Sharing restrictions do not block attribute-only requests, so the proof checks a data read without changing product stat access.
Public disclosure review