fix(plugin): resolve Windows Node to an absolute executable - #788
Open
xinoai wants to merge 2 commits into
Open
Conversation
xinoai
marked this pull request as ready for review
September 2, 2026 13:41
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
sylvesterkaczmarek
left a comment
Contributor
There was a problem hiding this comment.
Checked the Windows fallback path. The managed-runtime branches still win first; the PATH fallback now resolves one native node.exe through cmd's %~$ENV:I lookup and invokes that exact executable instead of doing a second command search. The native regression also covers quoted PATH entries, caller-directory shims/candidates, argument forwarding, exit status and no-runtime behavior. Looks sound.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Windows MCP launcher should select one Node executable and launch it consistently. Resolve
node.exefromPATHonce, then invoke its absolute path.Changes
whereand barenodecommands with the shell's built-in executable lookup.Testing
bun test --timeout 30000 tests-ts/mcp-launcher.test.ts: passed the MCP smoke test on Linux; native Windows case skipped.pnpm run types: passed.pnpm run format: passed.pnpm run test --seed 12345andpnpm run test: both passed on Linux (2,241 passed, 42 skipped in each run).Risk and rollout
The PATH fallback requires a native
node.exe. Installations using script-only PATH shims can use the existingCODEX_MCP_NODE_PATHoverride. No commands, flags, or public environment variables are added. The native Windows regression passed in CI.Public disclosure review