fix: restore batching for automatic finding matching - #782
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Local validation for c269641 passed:
|
sylvesterkaczmarek
left a comment
There was a problem hiding this comment.
The batching path looks sound. Large comparisons are recursively split on one side, so every before/after pair is still covered once; each batch is validated before combineComparisons, then the combined result is validated again against the full input. Cancellation still happens between calls, and the README now makes the out-of-budget model calls explicit. I don't see a blocker here.
Summary
Restore bounded batching for automatic post-scan history matching. The single-call restriction added in #638 can skip matching for a large history.
Changes
allowBatchingswitch and its two single-call tests.Testing
pnpm run types,pnpm run format, andpnpm run buildpassed.git diff --checkpassed.Risk and rollout
Automatic history matching can make several model calls. These calls remain outside the scan's recorded cost and
maxCostUsdlimit. This PR restores batching; it does not add post-scan budget accounting. No CLI flags or result formats change.Public disclosure review