feat(task): verify prompt file digests - #712
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: deebd7a815
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
--prompt-file-sha256 <digest>verification fortask --prompt-fileturn/start, including leading/trailing whitespace and the common final newlinepromptFileSha256receipt in foreground JSON and persisted background requests/resultsCodex review follow-up
Addressed the P2 finding in commit
a8f21dd:.trim()mismatch at the app-server transport boundarypromptSha256topromptFileSha256Verification
fix-issue-621-verify-prompt-file-digest: validnpm run build: passnpm run check-version: passgit diff --check: passFixes #621