2-phase attachment upload uses AttachmentUploadDescriptor which allows PUT and custom header passing (includes breaking changes) #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Attachment.upload_descriptorwhich specifies the upload method (post vs. put) and any custom headers to pass along.Breaking:
Attachment.upload_urlAttachmentsCreateReqfor phase 1 of a 2-phase upload, ChatKitServer callsawait self.store.save_attachment(attachment, context=context)after calling attachment_store's create method. Previously it was the responsibility of attachment_store to save the attachment to the data store, which forced the attachment store to have access to / depend on the thread data store.