Skip to content

VWEUDA: fix TypeError crash in update_result_from_payload() blocking all SoC updates #3800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benderl merged 1 commit into from
Aug 14, 2026
Merged

VWEUDA: fix TypeError crash in update_result_from_payload() blocking all SoC updates #3800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions packages/modules/vehicles/vweuda/libeuda.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,10 +813,23 @@ def update_result_from_payload(self, payload: dict, source: str) -> dict:
if result['soc'] is None:
_LOGGER.info("thread result skipped, no soc found")
_valid = False
if _valid and result['odometer'] is not None:
if vin in euda.result and result['odometer'] < euda.result[vin]['odometer']:
_LOGGER.info("odometer less than earlier - keep earlier value")
result['odometer'] = euda.result[vin]['odometer']
if _valid:
cached_odometer = euda.result[vin].get('odometer')
if result['odometer'] is None:
# newer payload carries no odometer reading - keep the
# last known value instead of dropping the whole update
result['odometer'] = cached_odometer
elif cached_odometer is not None:
try:
if float(result['odometer']) < float(cached_odometer):
_LOGGER.info("odometer less than earlier - keep earlier value")
result['odometer'] = cached_odometer
except (TypeError, ValueError):
_LOGGER.warning(
f"could not compare odometer values "
f"(new={result['odometer']!r}, cached={cached_odometer!r}); "
"keeping new value"
)
euda.result[vin] = result
_LOGGER.info("thread result is valid")
else:
Expand Down