Skip to content

modbusserver: init strings completely #3797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LKuemmel merged 1 commit into from
Aug 17, 2026
+7 −5
Merged

modbusserver: init strings completely #3797

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions packages/helpermodules/modbusserver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,15 @@ def _form_int16(value: Union[int, float, bool], register: int):


def _form_str(value: Optional[str], register: int):
if value is None or len(value) == 0:
data_store[register] = 0
else:
string_max_length = 20
# initialize all registers to 0 to avoid leftover data from previous, longer values
for i in range(0, string_max_length):
data_store[register + i] = 0
if not (value is None or len(value) == 0):
bytes = value.encode("utf-8")
length = len(bytes)
if length > 20:
raise ValueError("String darf max 20 Zeichen enthalten.")
if length > string_max_length:
raise ValueError(f"String darf max {string_max_length} Zeichen enthalten.")
register_offset = 0
for i in range(0, length, 2):
try:
Expand Down