Prioritätensteuerung für Fahrzeuge - #3312
Open
LKuemmel wants to merge 15 commits into
Open
Conversation
LKuemmel
force-pushed
the
feature_loadmanagement_prio_list
branch
from
April 21, 2026 12:51
9ac373b to
110c159
Compare
LKuemmel
force-pushed
the
feature_loadmanagement_prio_list
branch
from
May 29, 2026 10:52
42ad4be to
a5a8ff5
Compare
LKuemmel
force-pushed
the
feature_loadmanagement_prio_list
branch
from
June 16, 2026 12:35
8adeb02 to
9139e0f
Compare
LKuemmel
force-pushed
the
feature_loadmanagement_prio_list
branch
from
July 8, 2026 12:13
a86fb17 to
a8dc062
Compare
LKuemmel
force-pushed
the
feature_loadmanagement_prio_list
branch
from
July 23, 2026 13:05
a2d2839 to
3a6e222
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 29 out of 29 changed files in this pull request and generated no new comments.
Suppressed comments (3)
packages/control/counter_all/hierarchy.py:335
- In
_add_missing_entrieswird in der Warnmeldungelement['id']verwendet, obwohl hier ein fehlender Eintrag ausdata_structureergänzt wird. In diesem Codepfad istelemententweder der zuletzt iterierte Hierarchie-Eintrag (falsche ID) oder bei leerer Hierarchie sogar nicht definiert (UnboundLocalError). Stattdessen sollte die neu hinzugefügte ID (entry_num) verwendet werden.
pub_system_message({}, f"{component_type_to_readable_text(type_name)} mit ID {element['id']} wurde"
packages/control/counter_all/counter_all_data.py:104
LoadmanagementPrioProtocol._remove_loadmanagement_prio_itemist typisiert als(entry: Dict) -> None, die Implementierung inLoadmanagementPrioMixinarbeitet aber mitList[Dict]und liefert einboolzurück. Das bricht Typprüfungen und erschwert die Weiterentwicklung (z.B. bei mypy/pyright).
def _remove_loadmanagement_prio_item(self, id: int, entry: Dict) -> None: ...
packages/control/counter_all/loadmanagement_prio.py:69
sort_cps_by_loadmanagement_prios_nestedgibt aktuell nur Ladepunkte zurück, deren EV-ID inloadmanagement_priosvorkommt. Wenn die Liste leer/unvollständig ist (z.B. beim ersten Start oder nach inkonsistenten Daten), werden verbleibende Chargepoints komplett ignoriert – die aufrufenden Algorithmen setzen dann für diese CPs keinen Strom mehr. Besser: alle nicht durch Prioritäten abgedeckten CPs am Ende als Fallback-Gruppe (in preferenced Reihenfolge) anhängen.
sorted_cps = []
for entry in self.data.get.loadmanagement_prios:
ndrsnhs
approved these changes
Aug 18, 2026
LKuemmel
force-pushed
the
feature_loadmanagement_prio_list
branch
from
August 18, 2026 09:25
9909442 to
e454e3b
Compare
LKuemmel
force-pushed
the
feature_loadmanagement_prio_list
branch
from
August 18, 2026 10:47
060ad6e to
e454e3b
Compare
LKuemmel
force-pushed
the
feature_loadmanagement_prio_list
branch
from
August 18, 2026 10:53
e454e3b to
6f13dad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.