feat: add standardized i18n notification keys (WEB-808)#74
feat: add standardized i18n notification keys (WEB-808)#74vaishnavirrapolu-06 wants to merge 4 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughA trailing newline (extra blank/whitespace line) was appended to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @IOhacker, just a gentle reminder for review when you get time. Thank you! |
|
CLA check = Passed |
gkbishnoi07
left a comment
There was a problem hiding this comment.
please squash your commits and resolve the conflicts
I hear you! I’ll resolve the conflicts and squash all the commits into one clean update. Since I'm tied up with university work for the next two days, I’ll have the polished, squashed version pushed to this PR by Friday. Thank you! |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Line 25: The Windows-specific packages "@esbuild/win32-x64" and
"@rollup/rollup-win32-x64-msvc" are in dependencies and causing EBADPLATFORM on
non-Windows systems; remove these two entries from the "dependencies" section in
package.json and add identical entries (same version strings) under
"optionalDependencies" so npm will skip them on unsupported platforms and
Vite/build tools can still resolve platform-specific binaries.
In `@src/locales/es-ES/common.json`:
- Line 157: The Spanish locale contains English country names for keys "MU" and
"MW"; update their values to Spanish by replacing "Mauritius" with "Mauricio"
for key "MU" and "Malawi" with "Malaui" for key "MW" in
src/locales/es-ES/common.json so the locale remains fully localized.
In `@src/pages/login/Login.tsx`:
- Line 303: Replace the hardcoded English anchor texts in the Login component
with i18n calls — e.g., change the "User Group", other community/contribute menu
labels, and the repeated anchors (lines referenced around 303, 306, 309, 324,
327, 330) to use the t(...) function so localization is restored; update the JSX
anchor children to something like t('community.userGroup') (and corresponding
keys for the other links) within the Login component to match the existing
translation keys used elsewhere.
- Around line 219-220: The password input currently uses hardcoded English
strings for placeholder and aria-label (type toggled by showPassword in
Login.tsx); replace these hardcoded values with i18n keys using the project's
translation hook (e.g., call the component's t/translate function) and supply
keys like "login.passwordPlaceholder" and "login.togglePasswordAria" (or
similar) for both placeholder and aria-label so they render localized text;
ensure the Login component imports/uses the existing i18n hook (e.g.,
useTranslation) and update any tests or story text keys accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 01d626a5-e71e-405f-8a6a-fc86098a5534
📒 Files selected for processing (7)
.env.samplepackage.jsonsrc/locales/en-US/common.jsonsrc/locales/es-ES/common.jsonsrc/locales/fr-FR/common.jsonsrc/locales/it-IT/common.jsonsrc/pages/login/Login.tsx
💤 Files with no reviewable changes (1)
- .env.sample
0e73001 to
9c7db00
Compare
Add a newline at the end of the auth.json file
|
@vaishnavirrapolu-06 still there are 4 commits, squashing the commits will show you only 1 |
This PR adds a new notifications object to the common.json files for en-US, es-ES, fr-FR, and it-IT. This standardizes success and error messages across the application to improve consistency and support internationalization.
Related Issues:#WEB-808
Summary by CodeRabbit