Skip to content

feat: add standardized i18n notification keys (WEB-808)#74

Open
vaishnavirrapolu-06 wants to merge 4 commits into
openMF:devfrom
vaishnavirrapolu-06:feat/i18n-notifications-WEB-808
Open

feat: add standardized i18n notification keys (WEB-808)#74
vaishnavirrapolu-06 wants to merge 4 commits into
openMF:devfrom
vaishnavirrapolu-06:feat/i18n-notifications-WEB-808

Conversation

@vaishnavirrapolu-06
Copy link
Copy Markdown

@vaishnavirrapolu-06 vaishnavirrapolu-06 commented Mar 3, 2026

This PR adds a new notifications object to the common.json files for en-US, es-ES, fr-FR, and it-IT. This standardizes success and error messages across the application to improve consistency and support internationalization.

Related Issues:#WEB-808

Summary by CodeRabbit

  • Chores
    • Minor whitespace/formatting update to the authentication locale file (extra trailing newline/blank line). No translation keys or visible content were changed.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 60b66a84-f733-4080-aeb7-ce8f347b9ab6

📥 Commits

Reviewing files that changed from the base of the PR and between e9f8cc2 and 8bb9181.

📒 Files selected for processing (1)
  • src/locales/en-US/auth.json
✅ Files skipped from review due to trivial changes (1)
  • src/locales/en-US/auth.json

📝 Walkthrough

Walkthrough

A trailing newline (extra blank/whitespace line) was appended to src/locales/en-US/auth.json. No JSON keys, values, or structure were changed.

Changes

Cohort / File(s) Summary
Locale Formatting
src/locales/en-US/auth.json
Added a trailing newline / blank line after the closing } (formatting-only change).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I nibbled a gap at the file's tail,
A gentle hop that left no trail,
Now whitespace hums where endings meet,
A tidy nook—small, soft, and sweet. 🐇✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title claims to add standardized i18n notification keys, but the actual change only adds trailing whitespace to auth.json with no structural modifications to keys or values. Update the title to accurately reflect the change, such as 'fix: remove trailing whitespace in auth.json' or clarify if this PR should include the notification key additions mentioned in the title.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vaishnavirrapolu-06
Copy link
Copy Markdown
Author

Hi @IOhacker, just a gentle reminder for review when you get time. Thank you!

@DavidH-1
Copy link
Copy Markdown
Contributor

CLA check = Passed

Copy link
Copy Markdown
Collaborator

@gkbishnoi07 gkbishnoi07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash your commits and resolve the conflicts

@vaishnavirrapolu-06
Copy link
Copy Markdown
Author

please squash your commits and resolve the conflicts

I hear you! I’ll resolve the conflicts and squash all the commits into one clean update. Since I'm tied up with university work for the next two days, I’ll have the polished, squashed version pushed to this PR by Friday. Thank you!

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@package.json`:
- Line 25: The Windows-specific packages "@esbuild/win32-x64" and
"@rollup/rollup-win32-x64-msvc" are in dependencies and causing EBADPLATFORM on
non-Windows systems; remove these two entries from the "dependencies" section in
package.json and add identical entries (same version strings) under
"optionalDependencies" so npm will skip them on unsupported platforms and
Vite/build tools can still resolve platform-specific binaries.

In `@src/locales/es-ES/common.json`:
- Line 157: The Spanish locale contains English country names for keys "MU" and
"MW"; update their values to Spanish by replacing "Mauritius" with "Mauricio"
for key "MU" and "Malawi" with "Malaui" for key "MW" in
src/locales/es-ES/common.json so the locale remains fully localized.

In `@src/pages/login/Login.tsx`:
- Line 303: Replace the hardcoded English anchor texts in the Login component
with i18n calls — e.g., change the "User Group", other community/contribute menu
labels, and the repeated anchors (lines referenced around 303, 306, 309, 324,
327, 330) to use the t(...) function so localization is restored; update the JSX
anchor children to something like t('community.userGroup') (and corresponding
keys for the other links) within the Login component to match the existing
translation keys used elsewhere.
- Around line 219-220: The password input currently uses hardcoded English
strings for placeholder and aria-label (type toggled by showPassword in
Login.tsx); replace these hardcoded values with i18n keys using the project's
translation hook (e.g., call the component's t/translate function) and supply
keys like "login.passwordPlaceholder" and "login.togglePasswordAria" (or
similar) for both placeholder and aria-label so they render localized text;
ensure the Login component imports/uses the existing i18n hook (e.g.,
useTranslation) and update any tests or story text keys accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 01d626a5-e71e-405f-8a6a-fc86098a5534

📥 Commits

Reviewing files that changed from the base of the PR and between 645550a and 0e73001.

📒 Files selected for processing (7)
  • .env.sample
  • package.json
  • src/locales/en-US/common.json
  • src/locales/es-ES/common.json
  • src/locales/fr-FR/common.json
  • src/locales/it-IT/common.json
  • src/pages/login/Login.tsx
💤 Files with no reviewable changes (1)
  • .env.sample

Comment thread package.json Outdated
Comment thread src/locales/es-ES/common.json Outdated
Comment thread src/pages/login/Login.tsx Outdated
Comment thread src/pages/login/Login.tsx Outdated
@vaishnavirrapolu-06 vaishnavirrapolu-06 force-pushed the feat/i18n-notifications-WEB-808 branch from 0e73001 to 9c7db00 Compare April 10, 2026 16:08
@IOhacker
Copy link
Copy Markdown
Contributor

@vaishnavirrapolu-06 still there are 4 commits, squashing the commits will show you only 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants