718 technical debt align model field names and serializer names#932
Merged
calumbell merged 2 commits intoMay 25, 2026
Merged
Conversation
calumbell
approved these changes
May 25, 2026
Contributor
calumbell
left a comment
There was a problem hiding this comment.
Looks good on local with the front-end pointed at it. Changes to the actual logic are small and sensible in spite of the large number of lines changed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This boiled down to the chosen display side of CreatureAction being different than the model stuff. All changes were made to align those.
All other similar scenarios had solid reasons to NOT refactor.
No tests changed values, all tests remained passing.