fix: run notebook kernels as the requesting user in multi-user mode#142
Open
EllaFr wants to merge 1 commit into
Open
fix: run notebook kernels as the requesting user in multi-user mode#142EllaFr wants to merge 1 commit into
EllaFr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In multi-user mode the file endpoints isolate users through
UserFS, but the notebook endpoints don't apply the same boundary. The kernel is started as the server process rather than the requesting user,create_sessionopens the requested path without theUserFScheck the file APIs use, and sessions are keyed by session id with no owner.Run the notebook kernel as the requesting OS user via
sudo -u(mirroring howcreate_runnerruns commands), so cell code executes with that user's OS permissions rather than the server's. The Jupyter connection file is placed in/tmpand made group-readable to that user so the kernel can read it while the server stays its owner.create_sessionalso validates the notebook path throughUserFS.is_path_allowed, each session is bound to the requestingX-User-Idso execute, status and delete only work for its owner, and the kernel starts in the user's home so relative paths resolve there. Single-user mode is unchanged.Contributor License Agreement
Note
Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.