fix: preserve custom env vars in multi-user mode via sudo -E#141
Open
Blumlaut wants to merge 1 commit into
Open
fix: preserve custom env vars in multi-user mode via sudo -E#141Blumlaut wants to merge 1 commit into
Blumlaut wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In multi-user mode (
OPEN_TERMINAL_MULTI_USER=true), custom environment variables passed via theenvfield inPOST /executeare silently dropped.PtyRunnerwraps commands withsudo -u <user> -- bash -c "...", butsudoresets the environment by default for security. Theenvdict is passed tosubprocess.Popen, but never reaches the actual subprocess.This breaks any workflow that relies on injecting env vars (e.g.
GH_TOKENfor GitHub CLI authentication, API keys, custom config).Solution
Add
-Eflag tosudoto preserve the environment through the user switch.