Skip to content

Promote attributes used by hostmetrics system metrics to RC - #4055

Open
osullivandonal wants to merge 1 commit into
open-telemetry:mainfrom
osullivandonal:promote-system-attributes-used-in-hostmetrics
Open

osullivandonal wants to merge 1 commit into
open-telemetry:mainfrom
osullivandonal:promote-system-attributes-used-in-hostmetrics

Conversation

@osullivandonal

@osullivandonal osullivandonal commented Aug 31, 2026 •

Copy link
Copy Markdown
Member

Works towards #1804

Changes

Promotes to release candidate all attributes referenced by the system metrics that are emitted by the hostmetrics receiver. A follow-on PR will promote the corresponding system metrics to release candidate.

Some of the attributes here are not referenced directly by the hostmetrics receiver's configuration, the reason they have been moved to RC is that the metric that uses the attribute is being used by hostmetrics receiver.

Note: this work also touches the cpu and network registries, since some attributes used by system metrics live in those namespaces.

These attributes have been promoted to RC:

- system.device
- system.memory.state
- system.memory.linux.hugepages.state
- system.paging.state
- system.paging.direction
- system.filesystem.state
- system.filesystem.type
- system.filesystem.mode
- system.filesystem.mountpoint
- cpu.logical_number
- network.connection.state

Important

Pull request acceptance is subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above may be automatically rejected and closed.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Links to prototypes or existing instrumentations (when adding or changing conventions)
  • Disclose AI usage, see OTel GenAI policy:
    • no AI used
    • AI-assisted
    • bulk AI-generated
  • I have the experience and knowledge necessary to understand, review, and validate all content in this PR.1

Footnotes

  1. Yes, I can answer maintainer questions about the content of this PR without using AI. ↩

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Promotes several attribute definitions (primarily in the system namespace, plus related cpu and network attributes used by system metrics) from development to release_candidate, and updates the generated registry/docs surfaces and changelog accordingly as part of the broader effort to stabilize system semantic conventions (#1804).

Changes:

  • Updated attribute stability to release_candidate for system.device, several system.memory.*/system.paging.* enums, and system.filesystem.* attributes.
  • Promoted related attributes in other namespaces used by system metrics (cpu.logical_number, network.connection.state) to release_candidate.
  • Refreshed the generated attribute registry docs and added a .chloggen entry.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
model/system/registry.yaml Promotes multiple system.* attributes/enums to release candidate.
model/network/registry.yaml Promotes network.connection.state enum members and attribute to release candidate.
model/cpu/registry.yaml Promotes cpu.logical_number to release candidate.
docs/system/container-metrics.md Updates rendered stability badge for system.device in system container metrics docs.
docs/registry/attributes/system.md Updates generated registry page stability badges for affected system.* attributes/enums.
docs/registry/attributes/network.md Updates generated registry page stability badges for network.connection.state.
docs/registry/attributes/cpu.md Updates generated registry page stability badge for cpu.logical_number.
.chloggen/promote-system-attributes-used-in-hostmetrics.yaml Adds changelog entry describing the promotion.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

stability: release_candidate
deprecated:
reason: uncategorized
note: "Removed, report shared memory usage with `metric.system.memory.linux.shared` metric"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, the attribute shared should not be promoted to RC as its deprecated. This has been removed.

stability: development
stability: release_candidate
brief: "The filesystem mode"
examples: ["rw, ro"]
@osullivandonal
osullivandonal force-pushed the promote-system-attributes-used-in-hostmetrics branch 2 times, most recently from dc06045 to c82d5bf Compare August 31, 2026 13:31
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Waiting on reviewers · refreshed 2026-09-22 15:48 UTC

Review the latest changes.

Status above doesn't look right?
  • Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@ChrsMark ChrsMark left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. Left one question about the linux slab state attribute.

Comment thread model/system/registry.yaml Outdated
@osullivandonal
osullivandonal force-pushed the promote-system-attributes-used-in-hostmetrics branch from c82d5bf to e06b025 Compare September 2, 2026 08:42

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Promote `jvm.file_descriptor.count` and `jvm.file_descriptor.limit` metrics to `release_candidate`
note: Promote attributes used by hostmetrics system metrics to RC

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems there are some outstanding issues affecting some of these attributes. They maybe out-of-date and maybe SIG decided on them long time ago, but please, can you go through and resolve them? Thanks

This list is generated with AI, feel free to push back on relevance.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will take this back to SIG to discuss.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR created to rename system.device to system.device.name: #4119

Comment thread .chloggen/promote-system-attributes-used-in-hostmetrics.yaml
@lmolkova lmolkova moved this from Untriaged to Needs More Approval in Semantic Conventions Triage Sep 16, 2026
Promotes to release candidate all attributes referenced by the system
metrics that are emitted by the hostmetrics receiver. A follow-on PR
will promote the corresponding system metrics to release candidate.
@osullivandonal
osullivandonal force-pushed the promote-system-attributes-used-in-hostmetrics branch from e06b025 to 47f90e6 Compare September 22, 2026 15:46
@osullivandonal
osullivandonal requested a review from a team as a code owner September 22, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:system enhancement New feature or request

Projects

Status: Needs More Approval

Development

Successfully merging this pull request may close these issues.

8 participants