Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The added test does not verify deterministic response bytes or the endpoint’s run-listing semantics.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds OpenAI Assistants run-listing support to the GenAI mock server.
Changes:
- Adds three route-prefix variants for listing thread runs.
- Returns tracked runs or a default completed run.
- Registers the endpoint in mock-server tests.
File summaries
| File | Description |
|---|---|
assistants.py |
Implements run listing and fallback response. |
test_mock_server.py |
Adds the endpoint to parametrized tests. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lmolkova
force-pushed
the
mock-assistants-list-runs
branch
from
September 13, 2026 22:39
a076a9d to
6c583a4
Compare
Pull request dashboard statusWaiting on reviewers · refreshed 2026-09-17 06:53 UTC Review the latest changes. Status above doesn't look right?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
GET /v1/threads/<thread_id>/runs(and theopenai/and bare/threads/route prefixes) to the mock server.Returns a list of runs associated with the given thread, falling back to a default completed run if none have been tracked in memory yet.
Related: open-telemetry/semantic-conventions-genai#513