Instrumentations and GenAI: Add copilot review instructions, update agents.md#4457
Instrumentations and GenAI: Add copilot review instructions, update agents.md#4457lmolkova wants to merge 9 commits intoopen-telemetry:mainfrom
Conversation
2a21b17 to
cc1943d
Compare
51a4a36 to
1711efa
Compare
|
@Kludex I think you know how to do it right, would you be interested in reviewing this? thanks a lot! |
|
According to https://docs.github.com/en/copilot/how-tos/configure-custom-instructions/add-repository-instructions#creating-custom-instructions it doesn't ignore AGENTS.md. Why do you say it's ignoring it? 🤔 Is this toggle enabled? https://docs.github.com/en/copilot/how-tos/configure-custom-instructions/add-repository-instructions#enabling-or-disabling-custom-instructions-for-copilot-code-review |
@Kludex thank for the feedback! this is according to copilot docs - https://docs.github.com/en/copilot/reference/custom-instructions-support The review agent does not seem to be using agents.md, but copilot coding agent does. Some quotes from me chatting with copilot
|
Add review instructions: according to claude it ignores .github instructions when authoring, and github review bot ignores agents.md 🤷♀️ maybe it will change some day, but for now:
would appreciate any feedback on how to do it better