Skip to content

Instrumentations and GenAI: Add copilot review instructions, update agents.md#4457

Open
lmolkova wants to merge 9 commits intoopen-telemetry:mainfrom
lmolkova:genai-review-instructions
Open

Instrumentations and GenAI: Add copilot review instructions, update agents.md#4457
lmolkova wants to merge 9 commits intoopen-telemetry:mainfrom
lmolkova:genai-review-instructions

Conversation

@lmolkova
Copy link
Copy Markdown
Member

@lmolkova lmolkova commented Apr 16, 2026

Add review instructions: according to claude it ignores .github instructions when authoring, and github review bot ignores agents.md 🤷‍♀️ maybe it will change some day, but for now:

  • agents.md focus on authoring
  • copilot instructions on review
  • there is some duplication

would appreciate any feedback on how to do it better

@lmolkova lmolkova requested a review from a team as a code owner April 16, 2026 23:26
@lmolkova lmolkova added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 16, 2026
@lmolkova lmolkova force-pushed the genai-review-instructions branch 2 times, most recently from 2a21b17 to cc1943d Compare April 16, 2026 23:55
@lmolkova lmolkova added the gen-ai Related to generative AI label Apr 17, 2026
@MikeGoldsmith MikeGoldsmith changed the title GenAI: Add copilot reivew instructions GenAI: Add copilot review instructions Apr 17, 2026
Copy link
Copy Markdown
Member

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I wish there was a better way to define these once and link to them from the relevant places but doesn't look like it's possible right now.

Comment thread instrumentation-genai/AGENTS.md
Comment thread AGENTS.md
Comment thread AGENTS.md Outdated
Comment thread .github/instructions/instrumentation-genai.instructions.md
@lmolkova lmolkova force-pushed the genai-review-instructions branch from 51a4a36 to 1711efa Compare April 17, 2026 17:03
@lmolkova lmolkova changed the title GenAI: Add copilot review instructions Instrumentations and GenAI: Add copilot review instructions, update agents.md Apr 17, 2026
@lmolkova
Copy link
Copy Markdown
Member Author

@Kludex I think you know how to do it right, would you be interested in reviewing this? thanks a lot!

@lmolkova lmolkova removed the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 17, 2026
@Kludex
Copy link
Copy Markdown
Member

Kludex commented Apr 17, 2026

Comment thread AGENTS.md Outdated
@lmolkova
Copy link
Copy Markdown
Member Author

lmolkova commented Apr 20, 2026

According to https://docs.github.com/en/copilot/how-tos/configure-custom-instructions/add-repository-instructions#creating-custom-instructions it doesn't ignore AGENTS.md. Why do you say it's ignoring it? 🤔

Is this toggle enabled? https://docs.github.com/en/copilot/how-tos/configure-custom-instructions/add-repository-instructions#enabling-or-disabling-custom-instructions-for-copilot-code-review

@Kludex thank for the feedback!

this is according to copilot docs - https://docs.github.com/en/copilot/reference/custom-instructions-support

The review agent does not seem to be using agents.md, but copilot coding agent does.

Some quotes from me chatting with copilot

Copilot code review reads repository‑wide and path‑specific custom instruction files but does not use AGENTS.md (agent instructions are for cloud agents). See support matrix in Custom instructions support.

Add AGENTS.md when you expect cloud agents to act (detailed build/test/run steps, error workarounds, and explicit “trust this” instructions). This improves cloud agent reliability but is not required for Copilot code review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gen-ai Related to generative AI

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

7 participants