fix(pyramid): add missing http.response.status_code in duration metrics#4448
Open
dominod-dev wants to merge 1 commit intoopen-telemetry:mainfrom
Open
fix(pyramid): add missing http.response.status_code in duration metrics#4448dominod-dev wants to merge 1 commit intoopen-telemetry:mainfrom
dominod-dev wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
|
|
The new convention for metrics use http.response.status_code in metrics for http.server.request.duration metric: https://opentelemetry.io/docs/specs/semconv/http/http-metrics/#metric-httpserverrequestduration Only the old convention had the attribute for pyramid, but the new one was missing.
dominod-dev
force-pushed
the
add_http_response_status_code_pyramid
branch
from
38acff5 to
405d586
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The new convention for metrics use http.response.status_code in metrics for http.server.request.duration metric:
https://opentelemetry.io/docs/specs/semconv/http/http-metrics/#metric-httpserverrequestduration
Only the old convention had the attribute for pyramid, but the new one was missing.
Did not touch the changelog as I was not sure if i needed to create an issue first to reference it or if a PR is enough.
Type of change
How Has This Been Tested?
http.responses.status_code was missing from my metrics, this PR fixed it.
A test was added in to check that the attribute is correctly present.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.