fix(instrumentation): add OTEL_SEMCONV_STABILITY_OPT_IN to CLI args#4438
Open
alliasgher wants to merge 2 commits intoopen-telemetry:mainfrom
Open
fix(instrumentation): add OTEL_SEMCONV_STABILITY_OPT_IN to CLI args#4438alliasgher wants to merge 2 commits intoopen-telemetry:mainfrom
alliasgher wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
MikeGoldsmith
requested changes
Apr 15, 2026
Member
MikeGoldsmith
left a comment
MikeGoldsmith
left a comment
There was a problem hiding this comment.
Looks like you accidentally pushed unrelated changes to this particular PR. Please can you clean these up so it's just the env var change?
PS you'll also need to update the PR description to use the standard structure and add a changelog.
github-project-automation
Bot
moved this to Reviewed PRs that need fixes
in Python PR digest
OTEL_SEMCONV_STABILITY_OPT_IN was not registered in environment_variables.py so the opentelemetry-instrument CLI did not expose a --semconv_stability_opt_in argument. Add the constant so the auto-instrumentation argument parser picks it up through the opentelemetry_environment_variables entry-point. Fixes open-telemetry#3965 Signed-off-by: alliasgher <alliasgher123@gmail.com>
alliasgher
force-pushed
the
fix-semconv-stability-cli-arg
branch
from
f761ca9 to
533693a
Compare
Contributor
Author
|
Cleaned up — the branch now contains only the |
Signed-off-by: Ali <alliasgher123@gmail.com>
MikeGoldsmith
approved these changes
Apr 15, 2026
Member
MikeGoldsmith
left a comment
MikeGoldsmith
left a comment
There was a problem hiding this comment.
Looks good - thanks @alliasgher 👍🏻
github-project-automation
Bot
moved this from Reviewed PRs that need fixes
to Approved PRs
in Python PR digest
tammy-baylis-swi
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Register in
opentelemetry-instrumentation/src/opentelemetry/instrumentation/environment_variables.pyso thatopentelemetry-instrumentautomatically exposes a--semconv_stability_opt_inCLI argument via its env-var-driven arg parser.Without this registration the flag simply did not exist at the CLI level, forcing users to set the env var directly rather than using the instrumentation command's argument.
Fixes #3965
Type of change
Checklist
Unreleased / Added