Repository navigation
Fix the build - #20859
Merged
Merged
Fix the build#20859
Conversation
Use the renamed TEST_HASH_MAP constant in the Redis error classification test. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0e29dd24-2961-451c-8c29-a44d4b5ab078
Pull request dashboard statusWaiting on the author · refreshed 2026-10-22 15:43 UTC Move out of draft to request review. Status above doesn't look right?
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The single-line correction uses the existing initialized fixture and leaves no unresolved review issues.
No open issues 🎉
What changed in this PR
Corrects the Lettuce 5 async Redis error-classification test to use its existing fixture constant, addressing the stale reference that prevented test compilation.
Changes:
- Replaces
testHashMapwithTEST_HASH_MAPwithout changing the test’s intended behavior.
| File | Description |
|---|---|
| instrumentation/lettuce/lettuce-5.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/lettuce/v5_0/LettuceAsyncClientTest.java | Corrects the hash-map fixture reference. |
Review effort: Balanced
trask
marked this pull request as ready for review
October 22, 2026 16:00
zeitlinger
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the existing
TEST_HASH_MAPconstant in the Lettuce 5 Redis error classification test. The stale field name prevents CI from compiling tests.#20841 renamed the field from
testHashMaptoTEST_HASH_MAP, while #20778 added a test referencing the old name. Both changes merged without a textual conflict, leavingmainunable to compile the test.