Repository navigation
Require messaging header-name getters - #20786
Merged
Merged
Conversation
Pull request dashboard statusMerged · refreshed 2026-10-21 07:54 UTC Status above doesn't look right?
|
Co-authored-by: trask <218610+trask@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Split original PR into messaging-only component
Require messaging header-name getters
Oct 20, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The scoped contract change, carrier implementations, regression tests, and migration documentation are consistent, with no unresolved findings.
No open issues 🎉
What changed in this PR
Requires explicit messaging header-name enumeration in the incubator API, with Camel and Lambda SQS implementations.
Changes:
- Makes
getMessageHeaderNamesmandatory and documents the alpha API source break. - Adds carrier-specific header access and snapshots of header names.
- Strengthens tests for selectors, exact-name lookup, and empty headers.
| File | Description |
|---|---|
instrumentation/camel-2.20/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/camel/v2_20/CamelMessagingAttributesGetter.java |
Adds incoming-header access and enumeration. |
instrumentation/camel-2.20/javaagent-unit-tests/src/test/java/io/opentelemetry/javaagent/instrumentation/camel/v2_20/CamelMessagingAttributesGetterTest.java |
Tests headers, snapshots, and selectors. |
instrumentation/aws-lambda/aws-lambda-events-common-2.2/library/src/test/java/io/opentelemetry/instrumentation/awslambdaevents/common/v2_2/internal/SqsMessageAttributesGetterTest.java |
Tests SQS attributes and empty carriers. |
instrumentation/aws-lambda/aws-lambda-events-common-2.2/library/src/main/java/io/opentelemetry/instrumentation/awslambdaevents/common/v2_2/internal/SqsMessageAttributesGetter.java |
Adds message-attribute lookup and enumeration. |
instrumentation/aws-lambda/aws-lambda-events-common-2.2/library/src/main/java/io/opentelemetry/instrumentation/awslambdaevents/common/v2_2/internal/SqsEventAttributesGetter.java |
Returns no header names for batches. |
instrumentation-api-incubator/src/test/java/io/opentelemetry/instrumentation/api/incubator/semconv/messaging/MessagingHeadersTest.java |
Strengthens selector compatibility tests. |
instrumentation-api-incubator/src/test/java/io/opentelemetry/instrumentation/api/incubator/semconv/messaging/MessagingAttributesExtractorTest.java |
Updates the test getter contract. |
instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/messaging/MessagingAttributesGetter.java |
Removes the default enumeration implementation. |
CHANGELOG.md |
Documents the custom-getter migration. |
Review effort: Balanced
trask
reviewed
Oct 20, 2026
trask
marked this pull request as ready for review
October 20, 2026 21:59
trask
approved these changes
Oct 20, 2026
laurit
approved these changes
Oct 21, 2026
laurit
enabled auto-merge (squash)
October 21, 2026 07:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Messaging-only replacement for #20775, independent of the annotation changes. Makes
MessagingAttributesGetter.getMessageHeaderNamesabstract.Custom getters must return supported header names or an empty iterable when none are supported. Use a snapshot for mutable carriers: