Repository navigation
Conversation
Pull request dashboard statusWaiting on reviewers · refreshed 2026-10-23 20:26 UTC Review the latest changes. Status above doesn't look right?
|
Co-authored-by: trask <218610+trask@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Classify generic Redisson Redis server errors
Classify generic Redisson Redis server errors
Oct 20, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The bounded classifier preserves existing fallbacks, has focused coverage, and has no identified blocking issues.
No open issues 🎉
What changed in this PR
Improves Redisson error telemetry by classifying generic server errors with known Redis protocol codes while preserving exception-class fallbacks.
Changes:
- Restricts classification to decoder-marked generic exceptions and known prefixes.
- Adds unit coverage for classification and fallbacks, plus span and duration-metric coverage for
WRONGTYPE.
| File | Description |
|---|---|
| instrumentation/redisson/redisson-common-3.0/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/redisson/AbstractRedissonClientTest.java | Verifies WRONGTYPE span and metric attributes. |
| instrumentation/redisson/redisson-common-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/redisson/common/v3_0/RedissonDbAttributesGetter.java | Classifies known generic server errors. |
| instrumentation/redisson/redisson-3.0/javaagent-unit-tests/src/test/java/io/opentelemetry/javaagent/instrumentation/redisson/common/v3_0/RedissonDbAttributesGetterTest.java | Tests classification and exception fallbacks. |
| instrumentation/redisson/redisson-3.0/javaagent-unit-tests/build.gradle.kts | Adds the common instrumentation test dependency. |
Review effort: Balanced
trask
reviewed
Oct 20, 2026
Co-authored-by: trask <218610+trask@users.noreply.github.com>
Co-authored-by: trask <218610+trask@users.noreply.github.com>
trask
reviewed
Oct 21, 2026
Co-authored-by: trask <218610+trask@users.noreply.github.com>
Co-authored-by: trask <218610+trask@users.noreply.github.com>
trask
changed the title
Co-authored-by: trask <218610+trask@users.noreply.github.com>
trask
reviewed
Oct 23, 2026
Co-authored-by: trask <218610+trask@users.noreply.github.com>
Co-authored-by: trask <218610+trask@users.noreply.github.com>
trask
approved these changes
Oct 23, 2026
Use the shared VALUE script return type and wait through CompletableFuture instead of the removed RFuture.join API. Await callback completion before checking its effects. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Leave startup command mapping unchanged until Redisson.create completes, then enable the callback test's EVAL gate and client-side GET failure. This prevents the Redisson 4.8 cluster-detection EVAL from timing out and exporting an unexpected trace. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record Redis server-error prefixes as
error.typeon Redisson spans and database duration metrics, including errors mapped to dedicated exception subclasses, such asOOM.Capture prefixes directly from RESP error replies before completion callbacks run. Preserve case and punctuation without an allowlist or length cap; client-side failures and replies without a captured prefix retain exception-class fallback.