Classify AWS SDK service error codes by Copilot · Pull Request #20777 · open-telemetry/opentelemetry-java-instrumentation

Copilot · 2026-10-20T18:49:26Z

Use structured AWS service error codes for RPC error.type in preview conventions, retaining the existing exception-class fallback when codes are missing.

SDK v1: Read AmazonServiceException.getErrorCode().
SDK v2: Read AwsServiceException.awsErrorDetails().errorCode().
Preserve legacy HTTP classification and existing error handling.

opentelemetry-pr-dashboard · 2026-10-20T18:51:41Z

Pull request dashboard status

Merged · refreshed 2026-10-21 05:56 UTC

Status above doesn't look right?

Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

Co-authored-by: trask <218610+trask@users.noreply.github.com>

Copilot

🟢 Approval recommended

The narrow changes preserve existing fallback behavior and include focused mode coverage, with no unresolved findings.

No open issues 🎉

What changed in this PR

Updates AWS SDK v1 and v2 instrumentation to use structured service error codes for preview RPC error.type, preserving exception-class fallback and legacy HTTP classification.

Changes:

Extract nonblank service error codes from both SDKs.
Test service errors, fallback cases, and successful requests.
Wire RPC preview and duplicate-mode tests into check.

File	Description
instrumentation/aws-sdk/aws-sdk-2.2/library/src/test/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal/AwsSdkErrorTypeTest.java	Tests v2 classification and fallback behavior.
instrumentation/aws-sdk/aws-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal/AwsSdkRpcAttributesGetter.java	Extracts v2 service error codes.
instrumentation/aws-sdk/aws-sdk-2.2/library/build.gradle.kts	Adds v2 preview test variants.
instrumentation/aws-sdk/aws-sdk-1.11/library/src/test/java/io/opentelemetry/instrumentation/awssdk/v1_11/internal/AwsSdkErrorTypeTest.java	Tests v1 classification and fallback behavior.
instrumentation/aws-sdk/aws-sdk-1.11/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/internal/AwsSdkRpcAttributesGetter.java	Extracts v1 service error codes.
instrumentation/aws-sdk/aws-sdk-1.11/library/build.gradle.kts	Adds v1 preview test variants.

_{Review effort: Balanced}

Co-authored-by: trask <218610+trask@users.noreply.github.com>

trask · 2026-10-20T22:34:58Z

    }
-    String errorCode = details.errorCode();
-    return errorCode == null || errorCode.trim().isEmpty() ? null : errorCode;
+    return details.errorCode();


unrelated cleanup from another PR from earlier today

Co-authored-by: trask <218610+trask@users.noreply.github.com>

Assert the parsed service error code directly instead of dereferencing the optional raw response, which is null with the latest SDK. Keep the existing telemetry and missing-code fallback assertions for all shared test consumers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

🟡 Changes recommended

Removing DynamoDB blank-code normalization changes existing error classification even outside RPC preview.

2 open issues

_{Review effort: Balanced}

Co-authored-by: trask <218610+trask@users.noreply.github.com>

Copilot

🟢 Approval recommended

No blocking defects were identified; only a non-blocking test naming suggestion remains.

No open issues 🎉

1 previously missed issue

In code that hasn't changed since last review

Rename inline assertion parameters from value to val

instrumentation/aws-sdk/aws-sdk-2.2/testing/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/AbstractAws2ClientTest.java:569

[Testing] Non-blocking: rename both inline attribute-assertion parameters from value to val, keeping v for the nested lambdas. This follows .github/instructions/java-tests.instructions.md:235–236 and the existing assertions in this file; these outer parameters are assertion objects, not raw attribute values.

2 resolved since last review

_{Review effort: Balanced}

Initial plan

28bbbe7

Copilot AI assigned Copilot and trask Oct 20, 2026

opentelemetry-pr-dashboard Bot mentioned this pull request Oct 20, 2026

Pull Request Dashboard #18435

Open

Copilot started work on behalf of trask October 20, 2026 18:49

View session

Classify AWS SDK service error codes

fa342de

Co-authored-by: trask <218610+trask@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add structured AWS service error classification for SDK RPC~~ Classify AWS SDK service error codes Oct 20, 2026

Copilot finished work on behalf of trask October 20, 2026 19:05

Copilot AI requested a review from trask October 20, 2026 19:05

trask requested a balanced review from Copilot October 20, 2026 19:05

Copilot started reviewing on behalf of trask October 20, 2026 19:06

View session

Copilot AI reviewed Oct 20, 2026

View reviewed changes

trask reviewed Oct 20, 2026

View reviewed changes

Comment thread instrumentation/aws-sdk/aws-sdk-1.11/library/build.gradle.kts Resolved

Copilot started work on behalf of trask October 20, 2026 21:06

View session

Integrate AWS error-code coverage

4bd8aa2

Co-authored-by: trask <218610+trask@users.noreply.github.com>

Copilot finished work on behalf of trask October 20, 2026 22:00

Copilot AI requested a review from trask October 20, 2026 22:00

trask reviewed Oct 20, 2026

View reviewed changes

Comment thread ...n/java/io/opentelemetry/instrumentation/awssdk/v1_11/internal/AwsSdkRpcAttributesGetter.java Resolved

Copilot started work on behalf of trask October 20, 2026 22:16

View session

Return AWS service error codes directly

72e603b

Co-authored-by: trask <218610+trask@users.noreply.github.com>

Copilot finished work on behalf of trask October 20, 2026 22:28

Copilot AI requested a review from trask October 20, 2026 22:28

trask reviewed Oct 20, 2026

View reviewed changes

Comment thread instrumentation/aws-sdk/aws-sdk-1.11/library/build.gradle.kts Resolved

Copilot started work on behalf of trask October 20, 2026 22:40

View session

Use suite-owned AWS semconv executions

a8651e9

Co-authored-by: trask <218610+trask@users.noreply.github.com>

Copilot AI requested a review from trask October 20, 2026 22:48

Copilot finished work on behalf of trask October 20, 2026 22:48

trask marked this pull request as ready for review October 21, 2026 02:39

trask requested a review from a team as a code owner October 21, 2026 02:39

trask approved these changes Oct 21, 2026

View reviewed changes

opentelemetry-pr-dashboard Bot requested a balanced review from Copilot October 21, 2026 02:40

Copilot started reviewing October 21, 2026 02:41

View session

Copilot AI reviewed Oct 21, 2026

View reviewed changes

Comment thread ...ain/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal/DynamoDbAttributesGetter.java Resolved

Comment thread instrumentation/aws-sdk/aws-sdk-1.11/library/build.gradle.kts Resolved

Copilot started work on behalf of trask October 21, 2026 02:47

View session

Collect AWS SDK semconv metadata profiles

d9b9664

Co-authored-by: trask <218610+trask@users.noreply.github.com>

Copilot finished work on behalf of trask October 21, 2026 02:57

Copilot AI requested a review from trask October 21, 2026 02:57

trask requested a balanced review from Copilot October 21, 2026 03:53

Copilot started reviewing on behalf of trask October 21, 2026 03:54

View session

Copilot AI reviewed Oct 21, 2026

View reviewed changes

laurit approved these changes Oct 21, 2026

View reviewed changes

laurit merged commit e4bdd59 into main Oct 21, 2026
128 of 130 checks passed

laurit deleted the copilot/aws-sdk-service-error-classification branch October 21, 2026 05:56

trask mentioned this pull request Oct 22, 2026

Track explicit semconv error.type coverage #20681

Open

14 of 25 tasks

Copilot AI mentioned this pull request Oct 23, 2026

Decouple AWS SDK instrumentation from RPC semantic conventions #20894

Merged

Navigation Menu

Repository navigation

Classify AWS SDK service error codes - #20777

Classify AWS SDK service error codes#20777
laurit merged 7 commits into
mainfrom
copilot/aws-sdk-service-error-classification

Copilot AI commented Oct 20, 2026 •

edited by trask

Loading

Uh oh!

opentelemetry-pr-dashboard Bot commented Oct 20, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

trask Oct 20, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Copilot AI commented Oct 20, 2026 • edited by trask Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

opentelemetry-pr-dashboard Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request dashboard status

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Uh oh!

Uh oh!

trask Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Oct 20, 2026 •

edited by trask

Loading

opentelemetry-pr-dashboard Bot commented Oct 20, 2026 •

edited

Loading