Repository navigation
Conversation
Pull request dashboard statusWaiting on reviewers · refreshed 2026-10-22 04:58 UTC Review the latest changes. Status above doesn't look right?
|
Co-authored-by: trask <218610+trask@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Extract Redis server error prefixes from ReplyErrorException
Classify Rediscala Redis server errors
Oct 20, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The bounded classification preserves fallback behavior, has focused coverage, and has no identified blocking issues.
No open issues 🎉
What changed in this PR
Adds Redis server-error classification to Rediscala telemetry while preserving shared fallback behavior.
Changes:
- Recognizes known reply prefixes from
ReplyErrorException. - Tests
WRONGTYPEon spans and duration metrics, plus classification fallback cases.
| File | Description |
|---|---|
| instrumentation/rediscala-1.8/javaagent/src/test/scala/io/opentelemetry/javaagent/instrumentation/rediscala/v1_8/RediscalaClientTest.scala | Adds real Redis error telemetry coverage. |
| instrumentation/rediscala-1.8/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/rediscala/v1_8/RediscalaAttributesGetter.java | Classifies known Redis error prefixes. |
| instrumentation/rediscala-1.8/javaagent-unit-tests/src/test/java/io/opentelemetry/javaagent/instrumentation/rediscala/v1_8/RediscalaAttributesGetterTest.java | Tests recognized prefixes and fallback cases. |
Review effort: Balanced
trask
reviewed
Oct 20, 2026
Co-authored-by: trask <218610+trask@users.noreply.github.com>
Co-authored-by: trask <218610+trask@users.noreply.github.com>
trask
reviewed
Oct 21, 2026
Co-authored-by: trask <218610+trask@users.noreply.github.com>
trask
reviewed
Oct 21, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
trask
reviewed
Oct 21, 2026
Co-authored-by: trask <218610+trask@users.noreply.github.com>
trask
reviewed
Oct 21, 2026
Co-authored-by: trask <218610+trask@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
trask
reviewed
Oct 21, 2026
Co-authored-by: trask <218610+trask@users.noreply.github.com>
trask
reviewed
Oct 21, 2026
Co-authored-by: trask <218610+trask@users.noreply.github.com>
trask
marked this pull request as ready for review
October 22, 2026 04:57
trask
approved these changes
Oct 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
error.typeon Rediscala spans and database duration metrics to the first space-delimited error code in server replies carried byReplyErrorException, for exampleWRONGTYPEorCUSTOMCODE.Accept custom and future server error codes without an allowlist. Unrelated failures and replies without a usable prefix retain the canonical exception-class fallback.