Repository navigation
Conversation
Pull request dashboard statusWaiting on the author · refreshed 2026-10-20 18:17 UTC Move out of draft to request review. Status above doesn't look right?
|
Copilot
AI
changed the title
[WIP] Extend histogram() to support other metric types
Add typed metric assertion helpers
Oct 20, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The additions consistently follow the existing assertion pattern, with focused coverage and no identified blocking issues.
No open issues 🎉
What changed in this PR
Extends the composable histogram assertion pattern from #20741 to six additional metric types in testing-common.
Changes:
- Adds typed helpers for long/double sums and gauges, exponential histograms, and summaries.
- Tests metadata, unordered point matching, extra-point rejection, and incompatible-type rejection.
| File | Description |
|---|---|
| testing-common/src/test/java/io/opentelemetry/instrumentation/testing/InstrumentationTestRunnerTest.java | Adds helper coverage and metric fixtures. |
| testing-common/src/main/java/io/opentelemetry/instrumentation/testing/util/MetricAssertions.java | Adds six composable typed assertion helpers. |
Review effort: Balanced
trask
reviewed
Oct 20, 2026
trask
reviewed
Oct 20, 2026
Co-authored-by: trask <218610+trask@users.noreply.github.com>
Co-authored-by: trask <218610+trask@users.noreply.github.com>
Co-authored-by: trask <218610+trask@users.noreply.github.com>
trask
force-pushed
the
copilot/extend-histogram-to-other-metric-types
branch
from
October 21, 2026 02:09
c12fc00 to
cfb6cc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the composable histogram assertion pattern to long/double sums and gauges, exponential histograms, and summaries, then migrate existing test assertions to the flat helper form.
The migration preserves metric metadata, point expectations, aggregation checks, and existing collection-matching behavior. No production telemetry changes.
Stacked on #20741.