Repository navigation
Clarify dependency checks, module boundaries, and catalog updates - #20669
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: bac0b611-f54c-4a51-acfb-ee921c1ad1ec
Pull request dashboard statusMerged · refreshed 2026-10-18 09:17 UTC Status above doesn't look right?
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused documentation change matches the stated purpose and has no identified issues.
No open issues 🎉
What changed in this PR
Clarifies repository review guidance to reduce findings based on assumed dependency behavior.
Changes:
- Requires checking dependency versions and concrete implementations, including relevant initialization and registration, before reporting behavior-dependent defects.
| File | Description |
|---|---|
.github/copilot-instructions.md |
Adds dependency-behavior verification guidance. |
Review effort: Balanced
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: bac0b611-f54c-4a51-acfb-ee921c1ad1ec
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: bac0b611-f54c-4a51-acfb-ee921c1ad1ec
trask
marked this pull request as ready for review
October 18, 2026 00:45
laurit
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require review findings about library or framework behavior to be checked against the dependency versions and concrete implementations used by the PR, including initialization and registration. This should reduce false positives based on assumed dependency behavior or missed setup.
Clarify that instrumentation Gradle modules can support multiple library major versions, with separate modules needed when compatibility or build constraints prevent sharing.
Also apply the nightly catalog-generation rule to source metadata changes, so metadata-only reviews do not request regeneration of
docs/instrumentation-list.yaml.Examples behind these clarifications:
AutoCloseablecontract instead of the concrete instruments' idempotent-close contracts.host.idprovider registration: the allegedly removed telemetry was not previously auto-discovered because the provider was not registered with the SPI.