Skip to content

Clarify dependency checks, module boundaries, and catalog updates - #20669

Merged
laurit merged 3 commits into
mainfrom
trask-rejected-copilot-reviews
Oct 18, 2026
Merged

laurit merged 3 commits into
mainfrom
trask-rejected-copilot-reviews

Conversation

@trask

@trask trask commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

Require review findings about library or framework behavior to be checked against the dependency versions and concrete implementations used by the PR, including initialization and registration. This should reduce false positives based on assumed dependency behavior or missed setup.

Clarify that instrumentation Gradle modules can support multiple library major versions, with separate modules needed when compatibility or build constraints prevent sharing.

Also apply the nightly catalog-generation rule to source metadata changes, so metadata-only reviews do not request regeneration of docs/instrumentation-list.yaml.

Examples behind these clarifications:

  • SDK sampler support: the reported configuration was unavailable in the pinned SDK 1.66.0.
  • RocketMQ property initialization: an earlier setter already initialized the map before propagation.
  • Gradle suite realization: the pinned Gradle JVM-suite plugin already realized the relevant registrations.
  • Kafka lifecycle and close contracts: the finding did not establish a supported overlapping call path and applied the generic AutoCloseable contract instead of the concrete instruments' idempotent-close contracts.
  • host.id provider registration: the allegedly removed telemetry was not previously auto-discovered because the provider was not registered with the SPI.
  • JMS module split: the request prompted clarification that newer library APIs do not by themselves require another Gradle module.
  • OSHI catalog regeneration: the nightly-generation instruction already existed, but its file pattern did not cover the source metadata being reviewed.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: bac0b611-f54c-4a51-acfb-ee921c1ad1ec
@trask
trask requested a balanced review from Copilot October 17, 2026 20:46
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-10-18 09:17 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused documentation change matches the stated purpose and has no identified issues.

No open issues 🎉

What changed in this PR

Clarifies repository review guidance to reduce findings based on assumed dependency behavior.

Changes:

  • Requires checking dependency versions and concrete implementations, including relevant initialization and registration, before reporting behavior-dependent defects.
File Description
.github/​copilot-instructions.md Adds dependency-behavior verification guidance.

Review effort: Balanced

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: bac0b611-f54c-4a51-acfb-ee921c1ad1ec
@trask trask changed the title Clarify dependency behavior verification in code reviews Clarify dependency checks and generated catalog review guidance Oct 18, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: bac0b611-f54c-4a51-acfb-ee921c1ad1ec
@trask trask changed the title Clarify dependency checks and generated catalog review guidance Clarify dependency checks, module boundaries, and catalog updates Oct 18, 2026
@trask
trask marked this pull request as ready for review October 18, 2026 00:45
@trask
trask requested a review from a team as a code owner October 18, 2026 00:45
@opentelemetry-pr-dashboard
opentelemetry-pr-dashboard Bot requested a balanced review from Copilot October 18, 2026 00:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The instruction-only changes match the stated purpose and have no identified blocking issues.

No open issues 🎉

Review effort: Balanced

@laurit
laurit merged commit 1e2a884 into main Oct 18, 2026
70 checks passed
@laurit
laurit deleted the trask-rejected-copilot-reviews branch October 18, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants