Skip to content

Introduce InstrumentationConfigurator#1783

Open
breedx-splk wants to merge 4 commits into
open-telemetry:mainfrom
breedx-splk:instrumentation_configurator
Open

Introduce InstrumentationConfigurator#1783
breedx-splk wants to merge 4 commits into
open-telemetry:mainfrom
breedx-splk:instrumentation_configurator

Conversation

@breedx-splk

Copy link
Copy Markdown
Contributor

Currently, we have a limitation in that AutoService instrumentations that are automatically found and loaded on the classpath cannot really be customized. The service loader just loads them and then immediately calls install. This limits users ability to tweak specific instrumentations to their needs.

So this PR adds a new interface called InstrumentationConfigurator. Implementations of this are found on the classpath, loaded by the service loader, and then they are invoked with the instrumentation before install() is called. The instances have a name field, and this name field allows the configurator to be linked/matched to the correct instrumentation.

We already have the DSL, but we cannot create type-specific DSL wrappers for 3rd party or other user-specific instrumentations. We should expect to see 1st party instrumentation libraries, and we want there to be a nice, uniform way of configuring these.

If we like this approach, then later on we could consider adding support for InstrumentationConfigurator in the DSL as well.

@breedx-splk breedx-splk requested a review from a team as a code owner June 2, 2026 23:19
@codecov

codecov Bot commented Jun 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.90%. Comparing base (37ae421) to head (b723d2e).

Files with missing lines Patch % Lines
...tion/library/httpurlconnection/AddTestExtractor.kt 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1783      +/-   ##
==========================================
- Coverage   62.99%   62.90%   -0.09%     
==========================================
  Files         157      159       +2     
  Lines        3448     3464      +16     
  Branches      352      353       +1     
==========================================
+ Hits         2172     2179       +7     
- Misses       1179     1187       +8     
- Partials       97       98       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant