Introduce InstrumentationConfigurator#1783
Open
breedx-splk wants to merge 4 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1783 +/- ##
==========================================
- Coverage 62.99% 62.90% -0.09%
==========================================
Files 157 159 +2
Lines 3448 3464 +16
Branches 352 353 +1
==========================================
+ Hits 2172 2179 +7
- Misses 1179 1187 +8
- Partials 97 98 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we have a limitation in that
AutoServiceinstrumentations that are automatically found and loaded on the classpath cannot really be customized. The service loader just loads them and then immediately calls install. This limits users ability to tweak specific instrumentations to their needs.So this PR adds a new interface called
InstrumentationConfigurator. Implementations of this are found on the classpath, loaded by the service loader, and then they are invoked with the instrumentation beforeinstall()is called. The instances have a name field, and this name field allows the configurator to be linked/matched to the correct instrumentation.We already have the DSL, but we cannot create type-specific DSL wrappers for 3rd party or other user-specific instrumentations. We should expect to see 1st party instrumentation libraries, and we want there to be a nice, uniform way of configuring these.
If we like this approach, then later on we could consider adding support for
InstrumentationConfiguratorin the DSL as well.