Skip to content

Added scroll and fling to view-click. References #1576#1780

Open
DavidGrath wants to merge 2 commits into
open-telemetry:mainfrom
DavidGrath:issue-1576-scroll
Open

Added scroll and fling to view-click. References #1576#1780
DavidGrath wants to merge 2 commits into
open-telemetry:mainfrom
DavidGrath:issue-1576-scroll

Conversation

@DavidGrath

Copy link
Copy Markdown
Contributor

Adds scroll and fling. Adds suggestions from #1741 (comment) by @marandaneto

At this point, I think the instrumentation has gone beyond the name of "click". I'd like to ask how to address the nomenclature:

  • Move the non-click code to a new "gesture" instrumentation?
  • Rename the existing module instead?

@DavidGrath DavidGrath requested a review from a team as a code owner June 2, 2026 14:49
@codecov

codecov Bot commented Jun 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.72727% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.37%. Comparing base (7caaac3) to head (8fbd945).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...trumentation/view/click/ViewClickEventGenerator.kt 90.69% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1780      +/-   ##
==========================================
+ Coverage   62.99%   63.37%   +0.38%     
==========================================
  Files         157      157              
  Lines        3448     3492      +44     
  Branches      352      356       +4     
==========================================
+ Hits         2172     2213      +41     
  Misses       1179     1179              
- Partials       97      100       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DavidGrath

Copy link
Copy Markdown
Contributor Author

I'm not sure exactly why the x and y distances are negated. I assumed it would just be the vertical axis because of how the coordinate system works compared to a regular Cartesian plane with the y axis flipped. But yeah, I'll leave it like that

@breedx-splk breedx-splk added this to the 1.5.0 milestone Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants