Add carrier information in case of WiFi connection with SIM card.#1465
Add carrier information in case of WiFi connection with SIM card.#1465Hemant21KG wants to merge 1 commit into
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1465 +/- ##
==========================================
+ Coverage 63.16% 63.74% +0.58%
==========================================
Files 158 159 +1
Lines 3125 3153 +28
Branches 324 325 +1
==========================================
+ Hits 1974 2010 +36
+ Misses 1056 1045 -11
- Partials 95 98 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Hemant21KG I owe you a huge apology! I have no good/reasonable explanation for why this PR was left unreviewed and and without comment for so long. This is a nice contribution and I think we would like to proceed with it, but right now it will need a rebase. If you can do that, that would be awesome. Alternatively, feel free to create a new PR or give us the go ahead to recreate this on your behalf if you don't have time to come back to it. Once again, I'm so sorry that it took this long. This is not a normal thing here, it's pretty embarrassing, and I'm sincerely sorry. Hopefully we can work it out and get this merged. |
Fixed : #1435