Skip to content

Add carrier information in case of WiFi connection with SIM card.#1465

Open
Hemant21KG wants to merge 1 commit into
open-telemetry:mainfrom
dream-horizon-org:feat/network-detector
Open

Add carrier information in case of WiFi connection with SIM card.#1465
Hemant21KG wants to merge 1 commit into
open-telemetry:mainfrom
dream-horizon-org:feat/network-detector

Conversation

@Hemant21KG

Copy link
Copy Markdown

Fixed : #1435

@Hemant21KG Hemant21KG requested a review from a team as a code owner December 5, 2025 18:22
@linux-foundation-easycla

linux-foundation-easycla Bot commented Dec 5, 2025

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: Hemant21KG / name: Hemant Kumar Gehlot (a3c9f62)

@codecov

codecov Bot commented Dec 5, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.74%. Comparing base (6c189d0) to head (a3c9f62).
⚠️ Report is 154 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1465      +/-   ##
==========================================
+ Coverage   63.16%   63.74%   +0.58%     
==========================================
  Files         158      159       +1     
  Lines        3125     3153      +28     
  Branches      324      325       +1     
==========================================
+ Hits         1974     2010      +36     
+ Misses       1056     1045      -11     
- Partials       95       98       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@breedx-splk

Copy link
Copy Markdown
Contributor

@Hemant21KG I owe you a huge apology! I have no good/reasonable explanation for why this PR was left unreviewed and and without comment for so long.

This is a nice contribution and I think we would like to proceed with it, but right now it will need a rebase. If you can do that, that would be awesome. Alternatively, feel free to create a new PR or give us the go ahead to recreate this on your behalf if you don't have time to come back to it.

Once again, I'm so sorry that it took this long. This is not a normal thing here, it's pretty embarrassing, and I'm sincerely sorry. Hopefully we can work it out and get this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Network carrier information missing for WiFi connections despite SIM card availability

3 participants