Fix slotcar final orientation#162
Merged
xiyuoh merged 1 commit intoopen-rmf:mainfrom May 1, 2026
Merged
Conversation
Signed-off-by: kjchee <keai_jiang_chee@cgh.com.sg>
8 tasks
xiyuoh
approved these changes
May 1, 2026
Member
xiyuoh
left a comment
There was a problem hiding this comment.
Great catch! Thanks for the fix, tested and works as expected
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
=========================================
Coverage 0.00% 0
=========================================
Files 1368 0 -1368
Lines 134666 0 -134666
=========================================
+ Misses 134666 0 -134666
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix
Fixed bug
Robots do not rotate to the requested final orientation.
Fix applied
a. Root cause:
When a caller (specifically when processing final destination orientation) passes
dpos = Zero()along with arequested_heading, the early-returnif (dpos.norm() < 1e-3)always triggers first and returns 0.0. Therequested_headingis never processed, so the function reports rotation change = 0.0.b. Fix:
Added a
&& !requested_headingcheck so the early-return doesn't trigger when the caller actually requests a rotation.c. To Test:
patrol_A2with specific orientation 90 degree