fix: gpexpand fails if GP is compiled without enable_ic_proxy #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👍 👍 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR that shall fix current gpexpand behaviour.
Currently if you try to run gpexpand on a system which was compiled without --enable_icproxy steps within gpexpand will try to query GUC gp_interconnect_proxy_addresses which would not exist on it. That is why first I moved validation that GUC interconnect_type is set to proxy.
Also put a backslash before COPY in SQL statements as it would otherwise fail with message: ERROR: forbidden to COPY to file in Yandex Cloud
HINT: Anyone can COPY to stdout or from stdin. psql's \copy command also works for anyone.