feat: Add targeting match split reason#483
feat: Add targeting match split reason#483AleksandrasMaliuginas-vinted wants to merge 1 commit intoopen-feature:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the OpenFeature provider by adding a new resolution reason, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new Reason constant, TargetingMatchSplitReason, to the openfeature/provider.go file. This new reason indicates that a resolved flag value was the result of a dynamic evaluation that resolves to a percentage split. There are no review comments to address.
Signed-off-by: Aleksandras Maliuginas <aleksandras.maliuginas@vinted.com> Made-with: Cursor
fbc626a to
862e9e2
Compare
This PR
Notes
This reason is used in go-feature-flag lib: https://github.com/thomaspoignant/go-feature-flag/blob/916ae7747b17a62dc904ee6a5f02a57c7147da25/modules/core/flag/resolution_reason.go#L15