Skip to content

feat: Add targeting match split reason#483

Open
AleksandrasMaliuginas-vinted wants to merge 1 commit intoopen-feature:mainfrom
AleksandrasMaliuginas-vinted:targeting-match-split-reason
Open

feat: Add targeting match split reason#483
AleksandrasMaliuginas-vinted wants to merge 1 commit intoopen-feature:mainfrom
AleksandrasMaliuginas-vinted:targeting-match-split-reason

Conversation

@AleksandrasMaliuginas-vinted
Copy link
Copy Markdown

This PR

  • adds TARGETING_MATCH_SPLIT reason

Notes

This reason is used in go-feature-flag lib: https://github.com/thomaspoignant/go-feature-flag/blob/916ae7747b17a62dc904ee6a5f02a57c7147da25/modules/core/flag/resolution_reason.go#L15

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the OpenFeature provider by adding a new resolution reason, TARGETING_MATCH_SPLIT. This addition provides more granular detail for feature flag evaluations, specifically when a flag's value is determined by a percentage-based dynamic evaluation. This change aims to improve compatibility and reporting for external feature flag systems, such as the go-feature-flag library, that utilize this specific resolution type.

Highlights

  • New Resolution Reason: A new TARGETING_MATCH_SPLIT reason has been introduced to the openfeature/provider.go file. This reason is intended for dynamic evaluations that resolve to a percentage split.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Reason constant, TargetingMatchSplitReason, to the openfeature/provider.go file. This new reason indicates that a resolved flag value was the result of a dynamic evaluation that resolves to a percentage split. There are no review comments to address.

Signed-off-by: Aleksandras Maliuginas <aleksandras.maliuginas@vinted.com>
Made-with: Cursor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant