Skip to content

Add model architecture support to quantization job parameters#7007

Merged
A-Artemis merged 5 commits into
developfrom
aurelien/model-architecture-optimization
Jul 15, 2026
Merged

Add model architecture support to quantization job parameters#7007
A-Artemis merged 5 commits into
developfrom
aurelien/model-architecture-optimization

Conversation

@A-Artemis

@A-Artemis A-Artemis commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds the model name to the jobs card for quantization.

image

Checklist

  • The PR title and description are clear and descriptive
  • I have manually tested the changes
  • All changes are covered by automated tests
  • All related issues are linked to this PR (if applicable)
  • Documentation has been updated (if applicable)

@A-Artemis A-Artemis self-assigned this Jul 10, 2026
@A-Artemis
A-Artemis requested a review from a team as a code owner July 10, 2026 09:09
Copilot AI review requested due to automatic review settings July 10, 2026 09:09
@A-Artemis
A-Artemis requested a review from a team as a code owner July 10, 2026 09:09
@A-Artemis A-Artemis linked an issue Jul 10, 2026 that may be closed by this pull request
@github-actions github-actions Bot added TEST Any changes in tests Geti Backend Issues related to the Geti application server Geti UI Issues related to Geti application frontend labels Jul 10, 2026
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

🐳 Docker image sizes

Device Size
cpu 4013.1 MB (3.92 GB)
xpu 10801.7 MB (10.55 GB)
cuda 10208.3 MB (9.97 GB)

@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

⏱️ Backend import time — app.main

Accelerator Cumulative (s) Self (s)
cpu 4.365 0.003
xpu 4.548 0.003
cuda 4.557 0.004

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the quantization job contract so the backend receives the model architecture identifier, resolves it to a user-friendly architecture name, and exposes richer model metadata (name + architecture) for quantization jobs so the UI can display it on the jobs card.

Changes:

  • UI: include model_architecture_id when submitting quantization jobs and plumb the value through the quantization dialog.
  • Backend: add model_architecture_id/model_architecture_name to QuantizationJobParams and include {id,name,architecture} in quantization job metadata.
  • Tests: update UI and backend unit tests to cover the new parameters/metadata.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
application/ui/tests/models/model-details.spec.ts Updates mocked quantization job payload to include model_architecture_id.
application/ui/src/features/models/model-listing/model-variants/quantization-row.component.tsx Adds modelArchitectureId prop and passes it into the dialog.
application/ui/src/features/models/model-listing/model-variants/quantization-dialog/quantization-dialog.component.tsx Sends model_architecture_id in the quantization job submission payload.
application/ui/src/features/models/model-listing/model-variants/model-variant-tabs.component.tsx Wires model.architecture into QuantizationRow.
application/backend/tests/unit/models/jobs/test_quantization_job.py Updates quantization job params fixture for new required fields.
application/backend/tests/unit/execution/quantization/test_getitune_quantizer.py Updates quantization params in multiple tests for new required fields.
application/backend/tests/unit/api/routers/test_jobs.py Patches manifest lookup and asserts architecture id/name propagation into submitted job params.
application/backend/app/models/jobs/quantization_job.py Adds architecture fields and a computed model_name used for metadata.
application/backend/app/api/schemas/jobs/quantization.py Extends request params and enriches quantization job metadata model fields.
application/backend/app/api/routers/jobs.py Resolves architecture name from manifest during quantize job submission and stores it in params.

Comment thread application/backend/app/api/routers/jobs.py
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

📊 Test coverage report

Metric Coverage
Lines 60.3%
Functions 57.0%
Branches 52.1%
Statements 59.9%

jpggvilaca
jpggvilaca previously approved these changes Jul 10, 2026

@jpggvilaca jpggvilaca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI LGTM

itallix
itallix previously approved these changes Jul 13, 2026
@A-Artemis
A-Artemis added this pull request to the merge queue Jul 13, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 13, 2026
@A-Artemis
A-Artemis added this pull request to the merge queue Jul 13, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 13, 2026
leoll2
leoll2 previously approved these changes Jul 13, 2026
@dwesolow
dwesolow dismissed stale reviews from leoll2, itallix, and jpggvilaca via f38d37c July 14, 2026 09:01
@A-Artemis
A-Artemis enabled auto-merge July 14, 2026 09:25

@jpggvilaca jpggvilaca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI LGTM

@A-Artemis
A-Artemis added this pull request to the merge queue Jul 15, 2026
Merged via the queue into develop with commit ad8e15b Jul 15, 2026
44 of 46 checks passed
@A-Artemis
A-Artemis deleted the aurelien/model-architecture-optimization branch July 15, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Geti Backend Issues related to the Geti application server Geti UI Issues related to Geti application frontend TEST Any changes in tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Model optimization job does not return architecture

6 participants