Add media navigation hotkeys and confirmation alternative#6934
Open
andersendsa wants to merge 8 commits into
Open
Add media navigation hotkeys and confirmation alternative#6934andersendsa wants to merge 8 commits into
andersendsa wants to merge 8 commits into
Conversation
Contributor
Author
|
Hi @dwesolow , @jpggvilaca pls let me know if this pr needs any changes or if it is good to merge |
Contributor
|
I quickly tested it, a few comments:
|
Contributor
Author
Hi @leoll2 I have done the changes could you pls trigger the checks again ? |
andersendsa
force-pushed
the
media_hotkeys
branch
from
July 18, 2026 13:00
890b74a to
b3d3c33
Compare
Contributor
Author
|
@leoll2 could you pls trigger the checks again ? |
andersendsa
force-pushed
the
media_hotkeys
branch
from
July 20, 2026 13:15
7112bf9 to
0680935
Compare
Contributor
Author
|
Hi @leoll2 I believe I have fixed the eslint and the unit tests could you pls trigger the checks again |
andersendsa
force-pushed
the
media_hotkeys
branch
from
July 20, 2026 14:49
913cc78 to
5dca09b
Compare
Contributor
Author
|
@leoll2 sorry the test was failing because of formatting error could u pls trigger the checks |
andersendsa
force-pushed
the
media_hotkeys
branch
from
July 20, 2026 15:03
94e88b6 to
883a8c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes : #6273
How to test
Checklist