feat: disable telemetry#229
Open
gabegorelick wants to merge 1 commit into
Open
Conversation
gabegorelick
commented
Jun 1, 2026
| // Log errors writing to checkpoint | ||
| processLoggerError(e.message); | ||
| } | ||
| // In the future, we will actually send telemetry here. |
Contributor
Author
There was a problem hiding this comment.
We should be able to drop in some other telemetry provider SDK or HTTP endpoint here.
Sending telemetry to Hashicorp is not doing us (or Hashicorp) any good. Even if we don't yet have our own telemetry solution yet (open-constructs#62), we should just disable telemetry for now. Fixes open-constructs#48
gabegorelick
force-pushed
the
disable-telemetry
branch
from
3086f09 to
ff7d998
Compare
gabegorelick
commented
Jun 1, 2026
| import { ReportRequest, ReportParams } from "@cdktn/commons"; | ||
| import nock from "nock"; | ||
|
|
||
| describe("ReportRequest", () => { |
Contributor
Author
There was a problem hiding this comment.
These tests don't cover anything if we're not sending telemetry somewhere over HTTP.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sending telemetry to Hashicorp is not doing us (or Hashicorp) any good. Even if we don't yet have our own telemetry solution yet (#62), we should just disable telemetry for now.
Related issue
Fixes #48
Description
Keep all the telemetry code, but just don't send the reports anywhere. This way, if/when we want to send telemetry somewhere, e.g. Sentry (#62), we can do so easily.
Checklist