feat(lib)!: remove creationStack#219
Draft
gabegorelick wants to merge 1 commit into
Draft
Conversation
AWS CDK removed them in aws/aws-cdk#37642 with the justification that they're slow and not used often enough to justify the cost. I think the same reasoning applies to cdktn. Fixes open-constructs#209 See open-constructs#215
8 tasks
gabegorelick
commented
May 28, 2026
| * Creates a throwable Error object that contains the token creation stack trace. | ||
| * @param message Error message | ||
| */ | ||
| protected newError(message: string): any { |
Contributor
Author
There was a problem hiding this comment.
As discussed in #215 (comment), this function is only used by Intrinsic.newError, which we are deleting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS CDK removed them in aws/aws-cdk#37642 with the justification that they're slow and not used often enough to justify the cost. I think the same reasoning applies to cdktn.
Fixes #209
See #215
Related issue
Fixes #209
Description
Don't capture stack traces at all.
Checklist