Skip to content

chore: remove some usages of cdktf from tests#186

Draft
gabegorelick wants to merge 1 commit into
open-constructs:mainfrom
gabegorelick:cdktf-provider-tests
Draft

chore: remove some usages of cdktf from tests#186
gabegorelick wants to merge 1 commit into
open-constructs:mainfrom
gabegorelick:cdktf-provider-tests

Conversation

@gabegorelick
Copy link
Copy Markdown
Contributor

@gabegorelick gabegorelick commented May 17, 2026

We have some tests that use cdktf providers instead of cdktn.

Description

Remove dependency on @cdktf/provider-* packages from tests. Also, install cdktn instead of cdktf in tests.

Checklist

  • I have updated the PR title to match CDKTN's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

We have some tests that use cdktf providers instead of cdktn.
@so0k
Copy link
Copy Markdown
Contributor

so0k commented May 30, 2026

should we pick this back up? We are not really supporting dual dependencies anymore and have been publishing pre-built providers for a while - do we still need to support really old cdktf providers?

@gabegorelick
Copy link
Copy Markdown
Contributor Author

Yes, we should finish this. The test failures should be fixable if we can get rid of cdktf support.

I can try to find the time to finish this. Otherwise, feel free to pick this up if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants