chore: remove some usages of cdktf from tests#186
Draft
gabegorelick wants to merge 1 commit into
Draft
Conversation
We have some tests that use cdktf providers instead of cdktn.
Contributor
|
should we pick this back up? We are not really supporting dual dependencies anymore and have been publishing pre-built providers for a while - do we still need to support really old cdktf providers? |
Contributor
Author
|
Yes, we should finish this. The test failures should be fixable if we can get rid of cdktf support. I can try to find the time to finish this. Otherwise, feel free to pick this up if you want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have some tests that use cdktf providers instead of cdktn.
Description
Remove dependency on
@cdktf/provider-*packages from tests. Also, installcdktninstead ofcdktfin tests.Checklist