Skip to content

Enhance release caching with missing IDs #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
google-labs-jules wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Enhance release caching with missing IDs #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/artist_tracker/tracker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,14 +623,10 @@ def _get_recent_releases(
logger.debug(f"Caching {len(releases)} releases for artist '{artist_name}'")
for release in releases:
try:
# Extract IDs from the release data
# Note: We need to store artist_id, album_id, track_id which aren't in the final release dict
# So we need to modify the release building code to include these IDs
# For now, cache with what we have - we'll need to enhance this
cache_data = {
'artist_id': artist_id,
'album_id': release.get('album_id', ''), # We need to add this to releases
'track_id': release.get('track_id', ''), # We need to add this to releases
'album_id': release.get('album_id', ''),
'track_id': release.get('track_id', ''),
'isrc': release['isrc'] if release['isrc'] != 'N/A' else None,
'release_date': release['release_date'],
'album_name': release['album'],
Expand Down