docs(readme): regenerate settings screenshots with address-bar rule#36
Merged
Merged
Conversation
The URL Rules pane gained an Address bar section (#29), so the shipped settings screenshots were stale. Regenerate all 12 (General, App Rules, URL Rules × en/zh-CN × light/dark) against the current UI. The URL Rules shots now show the address-bar rule turned on — `Set the input source in the address bar` enabled with Behavior, Input source, and Priority visible. The rule list is trimmed to two entries (a domain-suffix and a url-regex) to keep the taller pane framed, and Accessibility is now granted so no "requires Accessibility" notes appear. Signed-off-by: Kevin Cui <bh@bugs.cc>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (12)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches✨ Simplify code
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The URL Rules pane gained an Address bar section in #29, which left the shipped README screenshots out of date. This regenerates all 12 — General, App Rules, and URL Rules, each in English and Simplified Chinese, light and dark — against the current UI.
The URL Rules shots now show the address-bar rule turned on (
Set the input source in the address bar, with the Behavior, Input source, and Priority rows visible). The rule list is trimmed to two entries — onedomain-suffixand oneurl-regex— so the now-taller pane still frames cleanly, and Accessibility is granted in the captures so none of the "requires Accessibility" notes appear.The README markup is unchanged: the images are referenced by fixed filenames, so every language variant picks up the new screenshots automatically.