Skip to content

fix(about): drop stale swift-markdown-ui acknowledgement #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BlackHole1 merged 1 commit into from
Jun 24, 2026
+3 −4
Merged

fix(about): drop stale swift-markdown-ui acknowledgement #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Sources/LockIME/UI/AboutView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ struct AcknowledgementsView: View {

private let libraries: [Library] = [
.init(name: "Sparkle", license: "Sparkle License", url: URL(string: "https://github.com/sparkle-project/Sparkle")!),
.init(name: "swift-markdown-ui", license: "MIT License", url: URL(string: "https://github.com/gonzalezreal/swift-markdown-ui")!),
.init(name: "KeyboardShortcuts", license: "MIT License", url: URL(string: "https://github.com/sindresorhus/KeyboardShortcuts")!),
.init(name: "PermissionFlow", license: "MIT License", url: URL(string: "https://github.com/jaywcjlove/PermissionFlow")!),
]
Expand Down
4 changes: 2 additions & 2 deletions docs/DESIGN.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,8 @@ Background `.regularMaterial`. Rhythm: 28 top · icon **128** (`NSApp.applicatio
· 14 · name `.title` semibold · 2 · "Version x (y)" `.callout .secondary`
selectable · 12 · tagline `.subheadline .secondary` · 14 · links row · Spacer ·
copyright `.caption .tertiary` · 20 bottom. Links (`.buttonStyle(.link)`): GitHub,
Website, Acknowledgements (sheet listing Sparkle / swift-markdown-ui /
KeyboardShortcuts licenses).
Website, Acknowledgements (sheet listing Sparkle / KeyboardShortcuts /
PermissionFlow licenses).

### 4.4 Update window — Apple Software Update parity
Fixed **540×480**, non-reflowing across phases. Header: **real app icon 52pt**
Expand Down
2 changes: 1 addition & 1 deletion docs/RELEASING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ that file to the zip by basename and embeds it inline as a CDATA
`<description sparkle:format="markdown">` (`--embed-release-notes` is required —
markdown notes are not auto-embedded the way HTML fragments are), so the notes
travel with the appcast and need no hosting. The update window renders that
markdown natively with swift-markdown-ui — embedding **markdown, not a
markdown natively with its own parser — embedding **markdown, not a
pre-rendered HTML fragment**, which that view would show as raw tags. The same
file is reused verbatim as the GitHub Release `body`, so the Release page and the
update window can never disagree.
Expand Down
Loading