Skip to content

fix(android): apply codegen plugin unconditionally, not gated on isNewArchitectureEnabled #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rohit-till wants to merge 2 commits into
base: rohit/publish-github-package
Choose a base branch
from
Open

fix(android): apply codegen plugin unconditionally, not gated on isNewArchitectureEnabled #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dba2966
fix(android): apply codegen plugin unconditionally, not gated on isNe…
RohitDRey Sep 3, 2026
345ddc8
chore: bump version to 2.3.0
RohitDRey Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,11 @@ def isNewArchitectureEnabled() {

apply plugin: 'com.android.library'

if (isNewArchitectureEnabled()) {
apply plugin: 'com.facebook.react'
}
// Apply the RN codegen plugin unconditionally: RN's autolinking discovers this
// module's `libraryName` by regexing this file's text (findLibraryName.js), not by
// evaluating isNewArchitectureEnabled(), so it always expects codegen output here
// regardless of the consuming app's newArchEnabled setting.
apply plugin: 'com.facebook.react'

def getExtOrDefault(name) {
return rootProject.ext.has(name) ? rootProject.ext.get(name) : project.properties['EscPosPrinter_' + name]
Expand Down Expand Up @@ -131,10 +133,8 @@ dependencies {
// From node_modules
}

if (isNewArchitectureEnabled()) {
react {
jsRootDir = file("../src/")
libraryName = "EscPosPrinter"
codegenJavaPackageName = "com.reactnativeescposprinter"
}
react {
jsRootDir = file("../src/")
libraryName = "EscPosPrinter"
codegenJavaPackageName = "com.reactnativeescposprinter"
}
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@oolio-group/react-native-esc-pos-printer",
"version": "2.2.4",
"version": "2.3.0",
"description": "test",
"main": "lib/commonjs/index",
"module": "lib/module/index",
Expand Down