feat: whitelist Cloudflare metric hosts - #1
Open
ElioTohm wants to merge 1 commit into
Open
Conversation
ElioTohm
force-pushed
the
feature/host-whitelist-configmap
branch
from
August 18, 2026 07:24
523c188 to
acad5da
Compare
ElioTohm
force-pushed
the
feature/host-whitelist-configmap
branch
from
August 18, 2026 07:39
acad5da to
a60a7d5
Compare
chaosbox
reviewed
Aug 18, 2026
chaosbox
left a comment
There was a problem hiding this comment.
Could we simplify host_whitelist.go by decoding the file into a typed struct instead of manually walking yaml.Node?
If the accepted format is just:
type HostWhitelist struct {
Hosts []string yaml:"hosts" json:"hosts"
}
then yaml.Unmarshal can handle the parsing/validation, and this file can focus on reload behavior and exact host matching. The current manual schema checks make the implementation harder to follow and more brittle than it needs to be.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds optional host filtering for all Cloudflare exporter metrics that expose a
hostlabel. The whitelist is loaded from an externally managed ConfigMap mounted ashosts.yamland reloaded before each scrape.Type of Change
Testing
go test ./... -count=1go test ./... -race -count=1helm lintgit diff --checkConfiguration
Set
hostWhitelist.configMapNamein Helm values. The external ConfigMap must contain:The ConfigMap is mounted without
subPathso Kubernetes updates are observed automatically.Additional Notes
The fork retains the design and implementation plan commits alongside the feature commits.