Add LocalStack migration/adaptation plan and README pointer - #18
Add LocalStack migration/adaptation plan and README pointer#18ongeziwe17 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8504575ff8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| local-plan-backend: | ||
| AWS_ACCESS_KEY_ID=test AWS_SECRET_ACCESS_KEY=test AWS_DEFAULT_REGION=af-south-1 AWS_ENDPOINT_URL=http://localhost:4566 \ | ||
| tflocal -chdir=$(LOCALSTACK_BACKEND_DIR) init -reconfigure && \ | ||
| tflocal -chdir=$(LOCALSTACK_BACKEND_DIR) plan -var-file=localstack.tfvars |
There was a problem hiding this comment.
Keep mock AWS env vars for the whole recipe
In this proposed Makefile recipe, the inline AWS_* assignments only apply to the tflocal ... init command immediately following them; the && tflocal ... plan command runs as a separate simple command without those mock credentials/endpoints unless the user already exported them. When a developer copies this Makefile and runs make local-plan-backend from a clean shell, the plan step can therefore fall back to whatever ambient AWS configuration exists or fail credential checks, undermining the safety goal of these commands. Export the variables for the recipe/shell or repeat them on each command.
Useful? React with 👍 / 👎.
Motivation
Description
docs/localstack-migration-plan.md, a comprehensive migration/adaptation plan (inventory, feasibility, dual-mode architecture, provider/backend examples, variable patterns,docker-composeproposal, Makefile snippets, CI recommendations, pros/cons, risk checklist, and step-by-step implementation order).README.mdwith a new "LocalStack Deployment" section that points to the detailed plan and warns about LocalStack limitations (EC2/user-data/EIP/security-group differences).provider.localstack.tf,localstack.tfvars,docker-compose.localstack.ymlproposal, conditional Terraform patterns (count/ami_idoverride), and CI workflow draft for LocalStack validation.