Skip to content

Kan/add signature sub command#2068

Draft
Kay-Zee wants to merge 5 commits intomasterfrom
kan/add-signature-sub-command
Draft

Kan/add signature sub command#2068
Kay-Zee wants to merge 5 commits intomasterfrom
kan/add-signature-sub-command

Conversation

@Kay-Zee
Copy link
Member

@Kay-Zee Kay-Zee commented Sep 17, 2025

Closes #???

Description


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 3.84615% with 75 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/transactions/sign.go 5.35% 52 Missing and 1 partial ⚠️
internal/prompt/prompt.go 0.00% 16 Missing ⚠️
internal/transactions/transactions.go 0.00% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!


var addSigCommand = &command.Command{
Cmd: &cobra.Command{
Use: "add-sig <built transaction filename> <address> <signature>",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the full use be add-signature and then have a shorthand for add-sig?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants