Repository navigation
feat(i18n): add French locale across the avatar editor - #40
Open
youtsuhodev wants to merge 1 commit into
Open
youtsuhodev wants to merge 1 commit into
youtsuhodev wants to merge 1 commit into
Conversation
Add fr as a first-class AvatarLocale alongside en and zh-Hans. - Register the fr locale and its native label (Francais) in AVATAR_LOCALES so the language switcher renders it automatically. - Add a complete FR_TRANSLATIONS dictionary covering every UI string that already had a Simplified Chinese translation, including all face presets and animal breed labels. - Extend normalizeAvatarLocale to resolve fr and fr-* variants, and route translateAvatarText to the French dictionary. French browser locales now resolve automatically on first load. - Add hasAvatarTranslation so coverage tests can assert an explicit entry even when a French label matches the English one, such as proper nouns like Husky or Corgi. - Widen the locale type to 'en' | 'zh-Hans' | 'fr' in the React renderer, the Web mount options and custom element attribute parsing, and the Vue editor prop, and translate the language name in the Chinese dictionary. - Extend the locale spec with French normalization, translation, and face-preset/breed coverage assertions.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add fr as a first-class AvatarLocale alongside en and zh-Hans.
Register the fr locale and its native label (Francais) in AVATAR_LOCALES so the language switcher renders it automatically.
Add a complete FR_TRANSLATIONS dictionary covering every UI string that already had a Simplified Chinese translation, including all face presets and animal breed labels.
Extend normalizeAvatarLocale to resolve fr and fr-* variants, and route translateAvatarText to the French dictionary. French browser locales now resolve automatically on first load.
Add hasAvatarTranslation so coverage tests can assert an explicit entry even when a French label matches the English one, such as proper nouns like Husky or Corgi.
Widen the locale type to 'en' | 'zh-Hans' | 'fr' in the React renderer, the Web mount options and custom element attribute parsing, and the Vue editor prop, and translate the language name in the Chinese dictionary.
Extend the locale spec with French normalization, translation, and face-preset/breed coverage assertions.