Clarify and validate generated Objective-C asset symbol support#97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supersedes #93 while preserving the original contribution history by continuing from that branch head.
What changed
.mfiles.hfilesWhy
PR #93 fixes a real issue: resources referenced via generated Objective-C asset symbols such as
ACImageNameIcFlagwere previously reported as unused.Before merging, two points needed to be made explicit:
This follow-up keeps the conservative safety bias for
.hfiles and locks that decision down with tests.Validation
swift test --filter GeneratedAssetSymbolTestsswift testNotes