Repository navigation
Fix calculation, persistence, and profile state regressions - #399
Merged
Merged
Conversation
Keep nitrogen objectives consistent, preserve trace doses, and prevent stale results and profile responses from being reused. Serialize preference updates and report failed saves. Guard Windows build failures, isolate runtime test data, and remove unused controller properties and serialization wrappers. Add analytical and browser regression coverage and update the owning documentation. Validation: python scripts/test.py passed with 468 Python tests, 22 frontend tests, and the configured linters.
onethree7
marked this pull request as ready for review
October 15, 2026 21:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calculation and UI state could disagree with the current inputs: water edits could fail, urea objectives used different nitrogen coefficients from reported results, scaling could erase trace doses or retain stale results, and delayed profile/history responses could replace newer selections. Preference writes could also report success after failure or lose concurrent updates.
Correct those paths within the existing calculation and controller structure. Preserve zero nitrogen objectives, restore saved selections, serialize preference updates, guard native Windows build failures, and return valid diagnostics for malformed non-finite inputs. Remove unused controller properties and redundant serialization wrappers, isolate runtime test data, and update the owning documentation.
Validation:
python scripts/test.py -qpassed with 468 Python tests, 22 frontend tests, Ruff, ESLint, and Stylelint. Focused API and browser checks passed (27 tests);pip checkandgit diff --checkpassed. Installed Ruff was 0.16.1; the declaration pins 0.16.5. Native release packages were not built.