Repository navigation
Improve editor height, nitrogen sidebar and stock navigation - #398
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fertilizer editor stopped at 720 CSS pixels, leaving much of a large window unused. Let its table fill the remaining workspace height, with scrolling inside the table and the last product row reachable.
Stock solutions now has a permanent menu entry directly below Calculator. It opens the current Calculator recipe, keeps the selected menu state consistent and offers a clear prompt for an empty recipe. The existing Solver action still transfers its result into stock preparation. Navigation owns focus and scrolling throughout.
Replace the sidebar's Na:Mg card with NO3:NH4:UR (%), using the existing backend nitrogen shares. All three percentages refer to nitrogen mass. Update the workflow guide and all five locales.
Validation:
python scripts/test.py -q --tb=shortpasses (422 Python/browser tests, 19 JavaScript tests, Ruff, ESLint and Stylelint). Browser coverage includes editor height and its final row at 75/100/150%, mixed and zero nitrogen shares, stock navigation, empty recipes, back navigation and Solver handoff. Visually checked the editor and stock menu at 2560x1440 and 75% scale.The existing workspace checks were moved into scripts/workspace_smoke.cjs to keep the browser entrypoint under the enforced file-length limit; the previous checks remain intact.