Repository navigation
fix: keep edge labels clear, slow the flow with a speed control, and open delivered diagrams - #38
Merged
Merged
Conversation
…en, and have the skill use it
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Merged
Contributor
|
🎉 This PR is included in version 0.2.0-rc.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 0.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes from using the 0.1.0 skill on a real diagram.
fix(layout)). Full-card layouts never placed their edge labels: the viewer put each one at its route's midpoint, so routes sharing a trunk stacked their labels, and some landed on cards. Every layout now places labels clear of cards, other labels and other edges' lines. A label whose midpoint was already clear stays where it was, so diagrams that looked right don't move. A new test checks every shipped example (samples, archify gallery, skill and site examples); it found 21 failures before the fix.feat(viewer)). Flow timing is 1.5× slower by default. Pulse speed only ever followed drawn edge length; diagrams carry no real timing. While the flow plays, a button beside Play cycles 1×, 2× and 0.5× (also when presenting). The speed is kept in the link asspeed=, and video export records at it.feat(cli)).deliver --openopens the viewer in the default browser (open,xdg-open,start). When no browser opens it warns and still exits 0. The skill now delivers with--open.Docs: the site's viewer and CLI pages and the README cover the speed control, the
speedlink parameter and--open.Labels moved a few pixels in the workflow and lifecycle samples, so the Linux visual baselines need regenerating. A follow-up commit on this branch will update them from CI's
update-visualrun.