Repository navigation
feat: polish the package: phone layout, smaller files, card-fit and validator fixes - #32
Merged
Merged
Conversation
…idth in the card-fit measure
…entity card's button a job
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
🎉 This PR is included in version 0.1.0-rc.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 0.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stress-tested the package on 28 diagrams (every gallery sample plus edge cases: single node, self-loops, parallel edges, 8-level nesting, unicode/RTL/emoji, markup in every text field, up to 500 nodes and 250 messages) in Chromium, WebKit and Firefox, in light, dark and at phone width. No console errors, text overflow or page scroll anywhere; 500 nodes render in ~200 ms with no long tasks during flow or zoom. Fixes for what the run turned up:
delivertrims to the brands the diagram uses: ~669 KB → ~495 KB (−26%). Dev server, tests and site keep importingbrands.gendirectly.deliver -o: creates missing parent folders instead of failing with ENOENT.semantics/parallel-edge: architecture and dataflow give each card one in and one out port, so two edges running the same way between the same nodes draw as one line with stacked labels. Swimlanes and sequences are exempt.semantics/large-diagram: over 60 nodes. The authoring contract now mentions both.Not changed: grouped layouts of a few hundred nodes are slow in ELK (300 nodes in 20 groups ≈ 66 s; ≤100 nodes stays under 1.5 s). The wrap pass is needed for grouped graphs too, so the size warning is the mitigation.
Desktop positions at 1440px are unchanged, so the Linux visual baselines should hold; they couldn't be regenerated locally (no Docker), so CI's run is the check.
Tests: all unit suites (viewer 132), typecheck, viewer e2e, CLI e2e and smoke, and site unit/e2e all pass.